You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2016/12/14 13:45:24 UTC
[GitHub] activemq-artemis pull request #915: ARTEMIS-888 - AMQP headers arent always ...
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/915
ARTEMIS-888 - AMQP headers arent always set
https://issues.apache.org/jira/browse/ARTEMIS-888
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andytaylor/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #915
----
commit 2759ddce3d3b03fe77d1d145b2e3f63a3921b92a
Author: Andy Taylor <an...@gmail.com>
Date: 2016-12-14T13:43:19Z
ARTEMIS-888 - AMQP headers arent always set
https://issues.apache.org/jira/browse/ARTEMIS-888
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #915: ARTEMIS-888 - AMQP headers arent always ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #915: ARTEMIS-888 - AMQP headers arent always set
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/915
Ideally a client would receive what it sends in most cases, though for the header there is scope for change given its a mutable section. The durability and priority wouldnt typically change of course. Theres no logical difference between e.g not having the header section, and having one without the priority field set, or having it set to 4 which is the default when not present. Similarly with the durability (which defaults to false unlike JMS).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #915: ARTEMIS-888 - AMQP headers arent always set
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/915
So what are you trying to fix here exactly? If the values are defaults the there isn't actually a need to send the header and incur the overhead of encoding it. Also since Artemis converts all incoming AMQP messages if the original message had no header then it'd be preferable to not add one even though the Header is technically mutable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---