[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1184: Feature: Add schema ref, Part2 etcd/mongo implement

[GitBox <gi...@apache.org>]

little-cui commented on a change in pull request #1184:
URL: https://github.com/apache/servicecomb-service-center/pull/1184#discussion_r774951691



##########
File path: datasource/schema/schema.go
##########
@@ -20,12 +20,17 @@ package schema
 import (
 	"context"
 	"crypto/md5"
-	"encoding/hex"
+	"fmt"
+
+	"github.com/go-chassis/cari/discovery"
+)
+
+var (
+	ErrSchemaNotFound        = discovery.NewError(discovery.ErrSchemaNotExists, "schema ref not found.")
+	ErrSchemaContentNotFound = discovery.NewError(discovery.ErrSchemaNotExists, "schema content not found.")
 )
 
 type RefRequest struct {
-	Domain    string
-	Project   string
 	ServiceID string `json:"serviceId" bson:"service_id"`

Review comment:
       不带是因为，sc整体设计都是domain和project都是通过ctx来做隔离，数据设计上是没有的




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org