[GitHub] [incubator-druid] clintropolis opened a new pull request #7256: fix SequenceMetadata deserialization

[GitBox <gi...@apache.org>]

clintropolis opened a new pull request #7256: fix SequenceMetadata deserialization
URL: https://github.com/apache/incubator-druid/pull/7256
 
 
   Fixes #7252.
   
   I don't love this fix, am totally open to other ideas. This PR adds an abstract method to `SeekableStreamIndexTaskRunner` 
   ```
   abstract TypeReference<List<SequenceMetadata<PartitionIdType, SequenceOffsetType>>> getSequenceMetadataTypeReference();
   ```
   so that sub classes can create the correct `TypeReference` to allow deserialization of `SequenceMetadata` during task restore to function. This also means `SequenceMetadata` has been pulled out of `SeekableStreamIndexTaskRunner` and given the same generic parameters of `PartitionIdType` and `SequenceOffsetType`. This was sort of ugly because `SequenceMetadata` was calling methods on it's parent `SeekableStreamIndexTaskRunner`, so those methods now take a runner as an argument.
   
   Also fixed is an issue where a resumed task that was at the end offset would not correctly end the task, resulting in what was afaict a task stuck in it's read loop forever.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org