[GitHub] [james-project] ottoka commented on a change in pull request #753: JAMES-3674 : Support password salting and hash scheme upgrading

[GitBox <gi...@apache.org>]

ottoka commented on a change in pull request #753:
URL: https://github.com/apache/james-project/pull/753#discussion_r751974747



##########
File path: server/data/data-library/src/main/java/org/apache/james/user/lib/model/Algorithm.java
##########
@@ -27,63 +27,53 @@
 public class Algorithm {
 
     public enum HashingMode {
-        LEGACY(LEGACY_FACTORY),
-        DEFAULT(DEFAULT_FACTORY);
+        PLAIN,
+        SALTED,
+        LEGACY,
+        LEGACY_SALTED;

Review comment:
       I believe there are a lot of people like me out there stuck with a LEGACY password database, since there was no way of getting rid of it before. This patch can help, but must be able to handle the LEGACY modes as the starting point before moving on to PLAIN or preferably SALTED.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org