You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/27 09:02:24 UTC

[GitHub] [spark] BestOreo opened a new pull request #24720: [SPARK-27852][Spark Core] One updateBytesWritten operaton may be miss…

BestOreo opened a new pull request #24720: [SPARK-27852][Spark Core] One updateBytesWritten operaton may be miss…
URL: https://github.com/apache/spark/pull/24720
 
 
   …ed in DiskBlockObjectWriter.scala
   
   In DiskBlockObjectWriter.scala, there are 2 overload write functions, the first of which executes updateBytesWritten function while the other doesn't. I think writeMetrics should record all the information about writing operations, some data of which will be displayed in the Spark jobs UI such as the data size of shuffle read and shuffle write.
   
   ## What changes were proposed in this pull request?
   
   (Please fill in changes proposed in this fix)
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
   (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
   
   Please review https://spark.apache.org/contributing.html before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org