Re: DO NOT REPLY [Bug 27814] - javadoc task does not encode baskslashes when generating file list by useexternalfile

[Jesse Glick <je...@sun.com>]

Martijn Kruithof wrote:
>> Since this is at least a quasi-bug (not ours but we can fix it)

Assuming that the javadoc command's behavior is in fact correct and it 
is just the JDK documentation which is incomplete or misleading (which 
is my guess), then it is really an Ant bug.

>> and
>> has been confirmed fixed in HEAD, do we want to merge for 1.6.5?
> 
> Please no, it doesn't seem to be a total showstopper [...]

I guess +0 from me on merging it. Important only to some people, of 
course. Could wait for 1.7.

As I understand it, it affects people who set useexternalfile="true" 
when running <javadoc> on a source tree containing spaces in the name on 
Windows - the task breaks with a wacko error message.

The latter two conditions (Windows + spaces) probably represents the 
minority of users, but it means that e.g. NetBeans cannot safely set 
useexternalfile="true" in projects it creates, lest this bug be 
triggered - which in turn means that Javadoc generation will fail on big 
enough projects, because the command line for the classpath will get too 
big.

On the other hand, the average Windows user who is writing his or her 
own script by hand can choose whether or not to use the attribute; they 
probably do not need to both handle a big classpath *and* keep sources 
in a path with spaces. (Unfortunately when #27814 manifests itself, it 
is far from obvious what you did wrong.)

-J.

-- 
jesse.glick@sun.com   x22801   netbeans.org   ant.apache.org
if I had known it was harmless I would have killed it myself


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: DO NOT REPLY [Bug 27814] - javadoc task does not encode baskslashes when generating file list by useexternalfile

[Peter Reilly <pe...@apache.org>]

Jesse Glick wrote:

>
> I guess +0 from me on merging it. Important only to some people, of 
> course. Could wait for 1.7.
>
> As I understand it, it affects people who set useexternalfile="true" 
> when running <javadoc> on a source tree containing spaces in the name 
> on Windows - the task breaks with a wacko error message.
>
> The latter two conditions (Windows + spaces) probably represents the 
> minority of users, 

This is unfortunally probally *not* the case.

If the modification is small, and self-contained, and has been tested by 
people with dos boxes using directories with spaces and
using javadoc from 1.2, 1.3 and 1.4 where the documentation seems to 
imply that one needs to use \\,
it could be placed in the 1.6.5 build.

> but it means that e.g. NetBeans cannot safely set 
> useexternalfile="true" in projects it creates, lest this bug be 
> triggered - which in turn means that Javadoc generation will fail on 
> big enough projects, because the command line for the classpath will 
> get too big.

Ick!


>
> On the other hand, the average Windows user who is writing his or her 
> own script by hand can choose whether or not to use the attribute; 
> they probably do not need to both handle a big classpath *and* keep 
> sources in a path with spaces. (Unfortunately when #27814 manifests 
> itself, it is far from obvious what you did wrong.)

Ick!

I guess I am now +1 for making the change.

Peter

>
> -J.
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org