You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2024/08/07 07:37:34 UTC
Re: [PR] OPENNLP-1599 - Add "model.language" to opennlp-models (opennlp)
mawiesne commented on code in PR #641:
URL: https://github.com/apache/opennlp/pull/641#discussion_r1706531023
##########
opennlp-tools-models/src/test/java/opennlp/tools/models/AbstractModelLoaderTest.java:
##########
@@ -33,6 +33,8 @@ public void testLoadOpenNLPModel() throws Exception {
model.getModelSHA256());
assertEquals("langdetect-183.bin", model.getModelName());
assertEquals("1.8.3", model.getModelVersion());
+ assertEquals("unknown"
+ /* "root" <- correct value after OpenNLP models 1.0.1 */, model.getModelLanguage());
Review Comment:
> Yep. We can also wait until 1.0.1 is ready.
Marked PR as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org