You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Kihwal Lee (JIRA)" <ji...@apache.org> on 2013/05/30 19:13:20 UTC

[jira] [Commented] (HDFS-4862) SafeModeInfo.isManual() returns true when resources are low even if it wasn't entered into manually

    [ https://issues.apache.org/jira/browse/HDFS-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670500#comment-13670500 ] 

Kihwal Lee commented on HDFS-4862:
----------------------------------

{{isManual()}} itself seems okay. Resource monitor will automatically enter NN to safe mode on resource shortage. The problem is {{isInStartupSafeMode()}} relying on it. 

Following methods in {{BlockManager}} call {{isInStartupSafeMode()}}: 
processReport(), addStoredBlockImmediate(), countLiveNodes()
They all assume {{isInStartupSafeMode()}} to do what its name implies.

We can perhaps add a variable to keep track and check it && {{safeMode.isOn()}} from {{isInStartupSafeMode()}}.


                
> SafeModeInfo.isManual() returns true when resources are low even if it wasn't entered into manually
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4862
>                 URL: https://issues.apache.org/jira/browse/HDFS-4862
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
>            Reporter: Ravi Prakash
>
> HDFS-1594 changed isManual to this
> {code}
> private boolean isManual() {
>   return extension == Integer.MAX_VALUE && !resourcesLow;
> }
> {code}
> One immediate impact of this is that when resources are low, the NN will throw away all block reports from DNs. This is undesirable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira