You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Piotr Zarzycki <pi...@gmail.com> on 2017/11/06 20:28:15 UTC
Re: [Maven] Core module reporting errors
I just did one more look into the code. For example Maven complaining about
ObjectMap class in line 81 where it's function called delete - I remember
that there were the discussion about that, but what has been done for Ant
build in that matter?
Piotr
On Wed, Nov 1, 2017, 00:12 Piotr Zarzycki <pi...@gmail.com> wrote:
> Hi Harbs,
>
> Thanks for look into that. I'm not sure for 100% but those fails seems to
> influence application build. If I remove my local cached Royale failes and
> try to build Hello World it should download all the swc from the apache
> server. Unfortunately pom script complains that Core.swc doesn't exists. It
> look like those errors preventing from upload snapshot artifacts. I will
> definitely try to look into that once I finish Flex release.
>
> Of course that only my assumption,
> Piotr
>
>
>
> 2017-10-31 20:19 GMT+01:00 Harbs <ha...@gmail.com>:
>
>> Yeah. It looks like Sonar doesn’t know what to do with some valid code.
>> In particular, it seems to have trouble with CONFIG::debug in TLF code.
>>
>> > On Oct 31, 2017, at 9:16 PM, Harbs <ha...@gmail.com> wrote:
>> >
>> > It looks like those errors are coming from SonarQube.
>> >
>> > Some of them are definitely wrong. The following is perfectly fine code:
>> >
>> > itIs = Language.is <http://language.is/>(leftOperand, rightOperand);
>> >
>> > Harbs
>> >
>> >> On Oct 31, 2017, at 9:11 PM, Harbs <harbs.lists@gmail.com <mailto:
>> harbs.lists@gmail.com>> wrote:
>> >>
>> >> Interesting. It looks like there’s 18 of these.
>> >>
>> >> What’s reporting those errors?
>> >>
>> >> In the case of LocalFile, the error appears to be a real error. I
>> don’t know why the compiler didn’t catch that.
>> >>
>> >> In the case of AMFBinaryData, it’s a weird construct, but I’m not sure
>> whether it’s valid code or not:
>> >> if (e == 0)
>> >> (i = v * Math.pow(2, 23) / 2, v = Math.round(v * POW_2_52 / 2))
>> >>
>> >>> On Oct 31, 2017, at 8:19 PM, Piotr Zarzycki <
>> piotrzarzycki21@gmail.com <ma...@gmail.com>> wrote:
>> >>>
>> >>> Hi Guys,
>> >>>
>> >>> I just looked into the Maven latest build [1] and I see errors
>> reported in
>> >>> module Core. Build itself is not failing, but it should be actually.
>> >>>
>> >>> Just search console build using [ERROR] [2]. The worse thing is that
>> I'm
>> >>> not getting those problems in my local Maven build.
>> >>>
>> >>> [1] https://builds.apache.org/job/Royale-asjs/180/consoleFull <
>> https://builds.apache.org/job/Royale-asjs/180/consoleFull>
>> >>> [2] https://paste.apache.org/bk0F <https://paste.apache.org/bk0F>
>> >>>
>> >>> Piotr,
>> >>> --
>> >>>
>> >>> Piotr Zarzycki
>> >>>
>> >>> mobile: +48 880 859 557
>> >>> skype: zarzycki10
>> >>>
>> >>> LinkedIn: http://www.linkedin.com/piotrzarzycki <
>> http://www.linkedin.com/piotrzarzycki>
>> >>> <https://pl.linkedin.com/in/piotr-zarzycki-92a53552 <
>> https://pl.linkedin.com/in/piotr-zarzycki-92a53552>>
>> >>>
>> >>> GitHub: https://github.com/piotrzarzycki21 <
>> https://github.com/piotrzarzycki21>
>> >>
>> >
>>
>>
>
>
> --
>
> Piotr Zarzycki
>
> mobile: +48 880 859 557
> skype: zarzycki10
>
> LinkedIn: http://www.linkedin.com/piotrzarzycki
> <https://pl.linkedin.com/in/piotr-zarzycki-92a53552>
>
> GitHub: https://github.com/piotrzarzycki21
>
Re: [Maven] Core module reporting errors
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Not sure what you are referencing, but the Ant build does not call Sonar.
HTH,
-Alex
On 11/6/17, 12:28 PM, "Piotr Zarzycki" <pi...@gmail.com> wrote:
>I just did one more look into the code. For example Maven complaining
>about
>ObjectMap class in line 81 where it's function called delete - I remember
>that there were the discussion about that, but what has been done for Ant
>build in that matter?
>
>Piotr
>
>On Wed, Nov 1, 2017, 00:12 Piotr Zarzycki <pi...@gmail.com>
>wrote:
>
>> Hi Harbs,
>>
>> Thanks for look into that. I'm not sure for 100% but those fails seems
>>to
>> influence application build. If I remove my local cached Royale failes
>>and
>> try to build Hello World it should download all the swc from the apache
>> server. Unfortunately pom script complains that Core.swc doesn't
>>exists. It
>> look like those errors preventing from upload snapshot artifacts. I will
>> definitely try to look into that once I finish Flex release.
>>
>> Of course that only my assumption,
>> Piotr
>>
>>
>>
>> 2017-10-31 20:19 GMT+01:00 Harbs <ha...@gmail.com>:
>>
>>> Yeah. It looks like Sonar doesn’t know what to do with some valid code.
>>> In particular, it seems to have trouble with CONFIG::debug in TLF code.
>>>
>>> > On Oct 31, 2017, at 9:16 PM, Harbs <ha...@gmail.com> wrote:
>>> >
>>> > It looks like those errors are coming from SonarQube.
>>> >
>>> > Some of them are definitely wrong. The following is perfectly fine
>>>code:
>>> >
>>> > itIs = Language.is
>>><https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flanguag
>>>e.is%2F&data=02%7C01%7C%7C4431501356444862c20f08d52554f62d%7Cfa7b1b5a7b3
>>>4438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdata=XOzD2633UOybdPX
>>>o4vgYPqcmvTYBnLXCqr8l52NWPfI%3D&reserved=0>(leftOperand, rightOperand);
>>> >
>>> > Harbs
>>> >
>>> >> On Oct 31, 2017, at 9:11 PM, Harbs <harbs.lists@gmail.com <mailto:
>>> harbs.lists@gmail.com>> wrote:
>>> >>
>>> >> Interesting. It looks like there’s 18 of these.
>>> >>
>>> >> What’s reporting those errors?
>>> >>
>>> >> In the case of LocalFile, the error appears to be a real error. I
>>> don’t know why the compiler didn’t catch that.
>>> >>
>>> >> In the case of AMFBinaryData, it’s a weird construct, but I’m not
>>>sure
>>> whether it’s valid code or not:
>>> >> if (e == 0)
>>> >> (i = v * Math.pow(2, 23) / 2, v = Math.round(v * POW_2_52 / 2))
>>> >>
>>> >>> On Oct 31, 2017, at 8:19 PM, Piotr Zarzycki <
>>> piotrzarzycki21@gmail.com <ma...@gmail.com>> wrote:
>>> >>>
>>> >>> Hi Guys,
>>> >>>
>>> >>> I just looked into the Maven latest build [1] and I see errors
>>> reported in
>>> >>> module Core. Build itself is not failing, but it should be
>>>actually.
>>> >>>
>>> >>> Just search console build using [ERROR] [2]. The worse thing is
>>>that
>>> I'm
>>> >>> not getting those problems in my local Maven build.
>>> >>>
>>> >>> [1]
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.
>>>apache.org%2Fjob%2FRoyale-asjs%2F180%2FconsoleFull&data=02%7C01%7C%7C443
>>>1501356444862c20f08d52554f62d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0
>>>%7C636455969218628795&sdata=ysWlYPWnbqaJqNdTKiINU8jlmAvjj0UZlvaHP1PdCOw%
>>>3D&reserved=0 <
>>>
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.
>>>apache.org%2Fjob%2FRoyale-asjs%2F180%2FconsoleFull&data=02%7C01%7C%7C443
>>>1501356444862c20f08d52554f62d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0
>>>%7C636455969218628795&sdata=ysWlYPWnbqaJqNdTKiINU8jlmAvjj0UZlvaHP1PdCOw%
>>>3D&reserved=0>
>>> >>> [2]
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.a
>>>pache.org%2Fbk0F&data=02%7C01%7C%7C4431501356444862c20f08d52554f62d%7Cfa
>>>7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdata=NOd3w%
>>>2F7uzX%2BxcX%2FFyRaNoW8u2Z3kQdHgcoX%2Fln15EvU%3D&reserved=0
>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.
>>>apache.org%2Fbk0F&data=02%7C01%7C%7C4431501356444862c20f08d52554f62d%7Cf
>>>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdata=NOd3w
>>>%2F7uzX%2BxcX%2FFyRaNoW8u2Z3kQdHgcoX%2Fln15EvU%3D&reserved=0>
>>> >>>
>>> >>> Piotr,
>>> >>> --
>>> >>>
>>> >>> Piotr Zarzycki
>>> >>>
>>> >>> mobile: +48 880 859 557
>>> >>> skype: zarzycki10
>>> >>>
>>> >>> LinkedIn:
>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.link
>>>edin.com%2Fpiotrzarzycki&data=02%7C01%7C%7C4431501356444862c20f08d52554f
>>>62d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdat
>>>a=dL0AhFZKbM8HuynjqdAUZgev28A6KVTp2DoetqY1XmY%3D&reserved=0 <
>>>
>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.link
>>>edin.com%2Fpiotrzarzycki&data=02%7C01%7C%7C4431501356444862c20f08d52554f
>>>62d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdat
>>>a=dL0AhFZKbM8HuynjqdAUZgev28A6KVTp2DoetqY1XmY%3D&reserved=0>
>>> >>>
>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.lin
>>>kedin.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C4431501356444
>>>862c20f08d52554f62d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364559
>>>69218628795&sdata=3SkjqxBxrQ4IZyapQRXWn2qiQDkB16g4dKct1dadu2A%3D&reserve
>>>d=0 <
>>>
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link
>>>edin.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C44315013564448
>>>62c20f08d52554f62d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63645596
>>>9218628795&sdata=3SkjqxBxrQ4IZyapQRXWn2qiQDkB16g4dKct1dadu2A%3D&reserved
>>>=0>>
>>> >>>
>>> >>> GitHub:
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
>>>com%2Fpiotrzarzycki21&data=02%7C01%7C%7C4431501356444862c20f08d52554f62d
>>>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdata=c
>>>UCDRhLlLFUvIjvRQuH9w0D30n6xprRnKwnzjEYWbPc%3D&reserved=0 <
>>>
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
>>>com%2Fpiotrzarzycki21&data=02%7C01%7C%7C4431501356444862c20f08d52554f62d
>>>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdata=c
>>>UCDRhLlLFUvIjvRQuH9w0D30n6xprRnKwnzjEYWbPc%3D&reserved=0>
>>> >>
>>> >
>>>
>>>
>>
>>
>> --
>>
>> Piotr Zarzycki
>>
>> mobile: +48 880 859 557
>> skype: zarzycki10
>>
>> LinkedIn:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linke
>>din.com%2Fpiotrzarzycki&data=02%7C01%7C%7C4431501356444862c20f08d52554f62
>>d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdata=d
>>L0AhFZKbM8HuynjqdAUZgev28A6KVTp2DoetqY1XmY%3D&reserved=0
>>
>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpl.link
>>edin.com%2Fin%2Fpiotr-zarzycki-92a53552&data=02%7C01%7C%7C443150135644486
>>2c20f08d52554f62d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364559692
>>18628795&sdata=3SkjqxBxrQ4IZyapQRXWn2qiQDkB16g4dKct1dadu2A%3D&reserved=0>
>>
>> GitHub:
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
>>om%2Fpiotrzarzycki21&data=02%7C01%7C%7C4431501356444862c20f08d52554f62d%7
>>Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636455969218628795&sdata=cUCD
>>RhLlLFUvIjvRQuH9w0D30n6xprRnKwnzjEYWbPc%3D&reserved=0
>>