You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rnd972 (via GitHub)" <gi...@apache.org> on 2026/02/08 17:54:08 UTC

[PR] Bump react and react-dom version [airflow]

rnd972 opened a new pull request, #61649:
URL: https://github.com/apache/airflow/pull/61649

   This PR 
   - bumps react and react-dom to 19.2.4
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   - [X] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "rnd972 (via GitHub)" <gi...@apache.org>.
rnd972 commented on code in PR #61649:
URL: https://github.com/apache/airflow/pull/61649#discussion_r2801869881


##########
airflow-core/src/airflow/ui/package.json:
##########
@@ -53,9 +53,9 @@
     "i18next-http-backend": "^3.0.2",
     "next-themes": "^0.4.6",
     "node-sql-parser": "^5.3.10",
-    "react": "^19.2.1",
+    "react": "^19.2.4",

Review Comment:
   Verified that plugins load properly
   
   <img width="1628" height="1285" alt="Screenshot 2026-02-12 at 8 40 15 PM" src="https://github.com/user-attachments/assets/37447e93-da1c-40d1-9834-c2b5aea9e750" />
   <img width="1631" height="595" alt="Screenshot 2026-02-12 at 8 39 59 PM" src="https://github.com/user-attachments/assets/cfb2ba03-f140-41fd-8b18-89c343a95a0d" />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61649:
URL: https://github.com/apache/airflow/pull/61649#issuecomment-3926282247

   ### Backport failed to create: v3-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/22177975283'> Run details </a>
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
       <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>❌</td>
           <td>v3-1-test</td>
           <td><a href="https://github.com/apache/airflow/commit/84c2f7bac15b7b12f76cbaf224ea640431ae433d"><img src='https://img.shields.io/badge/Commit-84c2f7b-red' alt='Commit Link'></a></td>
       </tr>
   </table>
   
   You can attempt to backport this manually by running:
   
   ```bash
   cherry_picker 84c2f7b v3-1-test
   ```
   
   This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
   the files that need manual conflict resolution.
   
   After you have resolved the conflicts, you can continue the backport process by running:
   
   ```bash
   cherry_picker --continue
   ```
   
   If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #61649:
URL: https://github.com/apache/airflow/pull/61649#discussion_r2788570056


##########
airflow-core/src/airflow/ui/package.json:
##########
@@ -53,9 +53,9 @@
     "i18next-http-backend": "^3.0.2",
     "next-themes": "^0.4.6",
     "node-sql-parser": "^5.3.10",
-    "react": "^19.2.1",
+    "react": "^19.2.4",

Review Comment:
   Just a comment to not merge by mistake. I want to explicitly check that this is not breaking plugins. (edge3 provider plugin for instance).
   
   We had some errors related to react-router-dom before.
   
   Even if patch releases are less likely to have such issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "rnd972 (via GitHub)" <gi...@apache.org>.
rnd972 commented on code in PR #61649:
URL: https://github.com/apache/airflow/pull/61649#discussion_r2801869881


##########
airflow-core/src/airflow/ui/package.json:
##########
@@ -53,9 +53,9 @@
     "i18next-http-backend": "^3.0.2",
     "next-themes": "^0.4.6",
     "node-sql-parser": "^5.3.10",
-    "react": "^19.2.1",
+    "react": "^19.2.4",

Review Comment:
   Verified that plugins load properly
   
   <img width="1631" height="595" alt="Screenshot 2026-02-12 at 8 39 59 PM" src="https://github.com/user-attachments/assets/cfb2ba03-f140-41fd-8b18-89c343a95a0d" />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #61649:
URL: https://github.com/apache/airflow/pull/61649


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "rnd972 (via GitHub)" <gi...@apache.org>.
rnd972 commented on PR #61649:
URL: https://github.com/apache/airflow/pull/61649#issuecomment-3918370794

   > Sorry for the delay, working as expected. Can you rebase and solve conflicts so we can merge.
   > 
   > (This is for react app plugins, there is documentation about it `docs/howto/custom-view-plugin.rst` and the edge provider uses such plugins, so running breeze with `--executor EdgeProvider` will run the edge provider, and in the UI you will see the plugin)
   > 
   > <img alt="Image" width="1771" height="967" src="https://private-user-images.githubusercontent.com/14861206/551059363-bc3ed371-662d-429e-b582-5da4e7c3da55.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzEzODU3NzEsIm5iZiI6MTc3MTM4NTQ3MSwicGF0aCI6Ii8xNDg2MTIwNi81NTEwNTkzNjMtYmMzZWQzNzEtNjYyZC00MjllLWI1ODItNWRhNGU3YzNkYTU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE4VDAzMzExMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRlZjY0YWQwZmIxZWZjZDMyZWM4YTc0ODA0YzUwZjc5MGNjNjVjMzU3MTU5MzNjNTU2YzBiNTlmNGFmMjkwOWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.UhTbHp_tEeqafanOi7TJFcN4UXMdSnoMkhhR_YDJDTU">
   
   Thanks for the link and for helping verifying the plugins! I have rebased and resolved the conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #61649:
URL: https://github.com/apache/airflow/pull/61649#issuecomment-3928055890

   Marking for 3.2.0. Not backporting. Depends on other dependencies upgrade that are not merged and should wait for 3.2.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "rnd972 (via GitHub)" <gi...@apache.org>.
rnd972 commented on code in PR #61649:
URL: https://github.com/apache/airflow/pull/61649#discussion_r2789192849


##########
airflow-core/src/airflow/ui/package.json:
##########
@@ -53,9 +53,9 @@
     "i18next-http-backend": "^3.0.2",
     "next-themes": "^0.4.6",
     "node-sql-parser": "^5.3.10",
-    "react": "^19.2.1",
+    "react": "^19.2.4",

Review Comment:
   Thanks for the review. I'll work on upgrading the problematic packages.
   
   Sorry, I am bit new to contributing to airflow. Can I ask if there are instructions on how to verify the plugins?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #61649:
URL: https://github.com/apache/airflow/pull/61649#issuecomment-3867750630

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump react and react-dom version [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #61649:
URL: https://github.com/apache/airflow/pull/61649#issuecomment-3926273732

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org