Default SearchComponents and SolrCoreAware

[Grant Ingersoll <gs...@apache.org>]

Am I reading the SolrCore code correctly in that it seems to indicate  
that the default SearchComponents are not checked if they are  
SolrCoreAware due to the fact that they are not instantiated with the  
SolrResourceLoader?

See the method loadSearchComponents() in SolrCore (around lines 907 or  
so)

I'm working on a new default component that I would like to be  
SolrCoreAware and I noticed, during debugging, that it's inform method  
is not being called.

Thanks,
Grant

Re: Default SearchComponents and SolrCoreAware

[Noble Paul നോബിള്‍ नोब्ळ् <no...@corp.aol.com>]

I guess default components should be treated similar to other
components and they should be loaded using SolrResourceLoader



On Sun, Jun 7, 2009 at 4:06 AM, Grant Ingersoll<gs...@apache.org> wrote:
> For the record, I don't believe they are checked if they are
> ResourceLoaderAware either.
>
> I have a pretty simple patch to fix it, assuming it is the right thing to
> do, which I think it is given that other SearchComponents can be core aware.
>
> -Grant
>
>
> On Jun 6, 2009, at 6:23 PM, Grant Ingersoll wrote:
>
>> Am I reading the SolrCore code correctly in that it seems to indicate that
>> the default SearchComponents are not checked if they are SolrCoreAware due
>> to the fact that they are not instantiated with the SolrResourceLoader?
>>
>> See the method loadSearchComponents() in SolrCore (around lines 907 or so)
>>
>> I'm working on a new default component that I would like to be
>> SolrCoreAware and I noticed, during debugging, that it's inform method is
>> not being called.
>>
>> Thanks,
>> Grant
>
>
>



-- 
-----------------------------------------------------
Noble Paul | Principal Engineer| AOL | http://aol.com

Re: Default SearchComponents and SolrCoreAware

[Grant Ingersoll <gs...@apache.org>]

For the record, I don't believe they are checked if they are  
ResourceLoaderAware either.

I have a pretty simple patch to fix it, assuming it is the right thing  
to do, which I think it is given that other SearchComponents can be  
core aware.

-Grant


On Jun 6, 2009, at 6:23 PM, Grant Ingersoll wrote:

> Am I reading the SolrCore code correctly in that it seems to  
> indicate that the default SearchComponents are not checked if they  
> are SolrCoreAware due to the fact that they are not instantiated  
> with the SolrResourceLoader?
>
> See the method loadSearchComponents() in SolrCore (around lines 907  
> or so)
>
> I'm working on a new default component that I would like to be  
> SolrCoreAware and I noticed, during debugging, that it's inform  
> method is not being called.
>
> Thanks,
> Grant