You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/11/06 19:29:18 UTC

Review Request 40031: UI hangs due to JS error at Configure Kerberos page on Enable Kerberos wizard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40031/
-----------------------------------------------------------

Review request for Ambari, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-13779
    https://issues.apache.org/jira/browse/AMBARI-13779


Repository: ambari


Description
-------

UI hangs due to JS error at Configure Kerberos page on Enable Kerberos wizard
This error was due to a password type config property not having a description and the description field is being refrenced for all password type properties without check


Diffs
-----

  ambari-web/app/models/configs/objects/service_config_property.js b4756c1 
  ambari-web/test/models/configs/objects/service_config_property_test.js f640a78 

Diff: https://reviews.apache.org/r/40031/diff/


Testing
-------

Verified that the patch works on a cluster
Verified that all existing and new unit tests works for ambari-web:
10288 tests complete (12 seconds)
105 tests pending


Thanks,

Jaimin Jetly


Re: Review Request 40031: UI hangs due to JS error at Configure Kerberos page on Enable Kerberos wizard

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40031/#review105492
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Nov. 6, 2015, 6:29 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40031/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 6:29 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13779
>     https://issues.apache.org/jira/browse/AMBARI-13779
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI hangs due to JS error at Configure Kerberos page on Enable Kerberos wizard
> This error was due to a password type config property not having a description and the description field is being refrenced for all password type properties without check
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/models/configs/objects/service_config_property.js b4756c1 
>   ambari-web/test/models/configs/objects/service_config_property_test.js f640a78 
> 
> Diff: https://reviews.apache.org/r/40031/diff/
> 
> 
> Testing
> -------
> 
> Verified that the patch works on a cluster
> Verified that all existing and new unit tests works for ambari-web:
> 10288 tests complete (12 seconds)
> 105 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>