You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/07/08 08:53:46 UTC
Review Request 72660: Added CSI volume type into the `Volume` protobuf
message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Added CSI volume type into the `Volume` protobuf message.
Diffs
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72660/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Qian Zhang <zh...@gmail.com>.
> On July 17, 2020, 2:52 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 3176-3177 (patched)
> > <https://reviews.apache.org/r/72660/diff/5/?file=2235803#file2235803line3176>
> >
> > As we discussed offline, the types of these fields probably need to change since secrets in the CSI spec consist of a string:string map. Maybe these fields could be of type `map<string, Secret>`?
So what is the key of `map<string, Secret>`? And in `NodePublishVolumeRequest`, the secret field is just a string to string map: `map<string, string> secrets`, so if we have `Secret` object in our secrets fields, how can we translate `Secret` object to the string to string map in `NodePublishVolumeRequest` when issuing the `NodePublishVolume` call?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/#review221240
-----------------------------------------------------------
On July 14, 2020, 2:44 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72660/
> -----------------------------------------------------------
>
> (Updated July 14, 2020, 2:44 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10147
> https://issues.apache.org/jira/browse/MESOS-10147
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed the `types.proto` file which has `VolumeCapability`
> defined as well so that we will have a single place (`mesos.proto`)
> to define this protobuf message.
>
>
> Diffs
> -----
>
> include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
> include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
> include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
> src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
> src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
> src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
> src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
> src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
> src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
> src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
> src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
> src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
> src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
> src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
> src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
> src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
> src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
> src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
>
>
> Diff: https://reviews.apache.org/r/72660/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/#review221240
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 3176-3177 (patched)
<https://reviews.apache.org/r/72660/#comment310087>
As we discussed offline, the types of these fields probably need to change since secrets in the CSI spec consist of a string:string map. Maybe these fields could be of type `map<string, Secret>`?
- Greg Mann
On July 14, 2020, 6:44 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72660/
> -----------------------------------------------------------
>
> (Updated July 14, 2020, 6:44 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10147
> https://issues.apache.org/jira/browse/MESOS-10147
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed the `types.proto` file which has `VolumeCapability`
> defined as well so that we will have a single place (`mesos.proto`)
> to define this protobuf message.
>
>
> Diffs
> -----
>
> include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
> include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
> include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
> src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
> src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
> src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
> src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
> src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
> src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
> src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
> src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
> src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
> src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
> src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
> src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
> src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
> src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
> src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
>
>
> Diff: https://reviews.apache.org/r/72660/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/#review221292
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On July 21, 2020, 3:09 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72660/
> -----------------------------------------------------------
>
> (Updated July 21, 2020, 3:09 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10147
> https://issues.apache.org/jira/browse/MESOS-10147
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed the `types.proto` file which has `VolumeCapability`
> defined as well so that we will have a single place (`mesos.proto`)
> to define this protobuf message.
>
>
> Diffs
> -----
>
> include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
> include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
> include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
> src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
> src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
> src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
> src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
> src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
> src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
> src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
> src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
> src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
> src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
> src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
> src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
> src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
> src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
> src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
>
>
> Diff: https://reviews.apache.org/r/72660/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/
-----------------------------------------------------------
(Updated July 21, 2020, 11:09 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Changed the type of the secret fields to `map`.
Bugs: MESOS-10147
https://issues.apache.org/jira/browse/MESOS-10147
Repository: mesos
Description
-------
Also removed the `types.proto` file which has `VolumeCapability`
defined as well so that we will have a single place (`mesos.proto`)
to define this protobuf message.
Diffs (updated)
-----
include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
Diff: https://reviews.apache.org/r/72660/diff/6/
Changes: https://reviews.apache.org/r/72660/diff/5-6/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/
-----------------------------------------------------------
(Updated July 14, 2020, 2:44 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Bugs: MESOS-10147
https://issues.apache.org/jira/browse/MESOS-10147
Repository: mesos
Description
-------
Also removed the `types.proto` file which has `VolumeCapability`
defined as well so that we will have a single place (`mesos.proto`)
to define this protobuf message.
Diffs (updated)
-----
include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
Diff: https://reviews.apache.org/r/72660/diff/5/
Changes: https://reviews.apache.org/r/72660/diff/4-5/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/
-----------------------------------------------------------
(Updated July 10, 2020, 10:30 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Bugs: MESOS-10147
https://issues.apache.org/jira/browse/MESOS-10147
Repository: mesos
Description
-------
Also removed the `types.proto` file which has `VolumeCapability`
defined as well so that we will have a single place (`mesos.proto`)
to define this protobuf message.
Diffs (updated)
-----
include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
Diff: https://reviews.apache.org/r/72660/diff/4/
Changes: https://reviews.apache.org/r/72660/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Qian Zhang <zh...@gmail.com>.
> On July 10, 2020, 7:47 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 3101 (patched)
> > <https://reviews.apache.org/r/72660/diff/3/?file=2235675#file2235675line3101>
> >
> > Since the required field in `CSIPluginInfo` is `type`, should this field be the `plugin_type`, since the name may not exist?
Yeah, I was thinking to name it `plugin_type`. However in CSI spec there is actually no plugin type concept, it only has plugin name (see https://github.com/container-storage-interface/spec/blob/v1.3.0/spec.md#getplugininfo) , since this is a user facing public protobuf message, I would suggest to make it aligned with CSI spec, and internally we need to map `plugin_name` here to the `CSIPluginInfo.type`.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/#review221170
-----------------------------------------------------------
On July 9, 2020, 11:13 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72660/
> -----------------------------------------------------------
>
> (Updated July 9, 2020, 11:13 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10147
> https://issues.apache.org/jira/browse/MESOS-10147
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed the `types.proto` file which has `VolumeCapability`
> defined as well so that we will have a single place (`mesos.proto`)
> to define this protobuf message.
>
>
> Diffs
> -----
>
> include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
> include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
> include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
> src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
> src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
> src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
> src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
> src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
> src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
> src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
> src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
> src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
> src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
> src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
> src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
> src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
> src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
> src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
>
>
> Diff: https://reviews.apache.org/r/72660/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 9, 2020, 11:47 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 3101 (patched)
> > <https://reviews.apache.org/r/72660/diff/3/?file=2235675#file2235675line3101>
> >
> > Since the required field in `CSIPluginInfo` is `type`, should this field be the `plugin_type`, since the name may not exist?
>
> Qian Zhang wrote:
> Yeah, I was thinking to name it `plugin_type`. However in CSI spec there is actually no plugin type concept, it only has plugin name (see https://github.com/container-storage-interface/spec/blob/v1.3.0/spec.md#getplugininfo) , since this is a user facing public protobuf message, I would suggest to make it aligned with CSI spec, and internally we need to map `plugin_name` here to the `CSIPluginInfo.type`.
OK, sgtm!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/#review221170
-----------------------------------------------------------
On July 10, 2020, 2:30 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72660/
> -----------------------------------------------------------
>
> (Updated July 10, 2020, 2:30 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10147
> https://issues.apache.org/jira/browse/MESOS-10147
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed the `types.proto` file which has `VolumeCapability`
> defined as well so that we will have a single place (`mesos.proto`)
> to define this protobuf message.
>
>
> Diffs
> -----
>
> include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
> include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
> include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
> src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
> src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
> src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
> src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
> src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
> src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
> src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
> src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
> src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
> src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
> src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
> src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
> src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
> src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
> src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
>
>
> Diff: https://reviews.apache.org/r/72660/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/#review221170
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 3101 (patched)
<https://reviews.apache.org/r/72660/#comment309954>
Since the required field in `CSIPluginInfo` is `type`, should this field be the `plugin_type`, since the name may not exist?
include/mesos/mesos.proto
Lines 3111 (patched)
<https://reviews.apache.org/r/72660/#comment309955>
Nit: s/Indicate/Indicates/
Here and below.
include/mesos/mesos.proto
Lines 3119 (patched)
<https://reviews.apache.org/r/72660/#comment309953>
Here, instead of "the CO", maybe we could say "Mesos and the plugin MUST NOT leak..."
include/mesos/mesos.proto
Lines 3164 (patched)
<https://reviews.apache.org/r/72660/#comment309956>
s/teh/the/
- Greg Mann
On July 9, 2020, 3:13 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72660/
> -----------------------------------------------------------
>
> (Updated July 9, 2020, 3:13 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10147
> https://issues.apache.org/jira/browse/MESOS-10147
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also removed the `types.proto` file which has `VolumeCapability`
> defined as well so that we will have a single place (`mesos.proto`)
> to define this protobuf message.
>
>
> Diffs
> -----
>
> include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
> include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
> include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
> include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
> include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
> src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
> src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
> src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
> src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
> src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
> src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
> src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
> src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
> src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
> src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
> src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
> src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
> src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
> src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
> src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
> src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
> src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
> src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
>
>
> Diff: https://reviews.apache.org/r/72660/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/
-----------------------------------------------------------
(Updated July 9, 2020, 11:13 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Removed `types.proto`.
Bugs: MESOS-10147
https://issues.apache.org/jira/browse/MESOS-10147
Repository: mesos
Description (updated)
-------
Also removed the `types.proto` file which has `VolumeCapability`
defined as well so that we will have a single place (`mesos.proto`)
to define this protobuf message.
Diffs (updated)
-----
include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d
include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff
include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792
src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05
src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470
src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8
src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3
src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2
src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234
src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736
src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0
src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc
src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544
src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654
src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47
src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478
src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357
src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182
src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf
src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0
Diff: https://reviews.apache.org/r/72660/diff/3/
Changes: https://reviews.apache.org/r/72660/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72660: Added CSI volume type into the `Volume`
protobuf message.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/
-----------------------------------------------------------
(Updated July 8, 2020, 4:58 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Minor changes.
Bugs: MESOS-10147
https://issues.apache.org/jira/browse/MESOS-10147
Repository: mesos
Description
-------
Added CSI volume type into the `Volume` protobuf message.
Diffs (updated)
-----
include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129
include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5
Diff: https://reviews.apache.org/r/72660/diff/2/
Changes: https://reviews.apache.org/r/72660/diff/1-2/
Testing
-------
Thanks,
Qian Zhang