You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/07 14:37:31 UTC
[GitHub] GJL commented on a change in pull request #6499: [hotfix] loose
dependency to mockito
GJL commented on a change in pull request #6499: [hotfix] loose dependency to mockito
URL: https://github.com/apache/flink/pull/6499#discussion_r208256964
##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -304,19 +318,149 @@ public void grantLeadership() throws Exception {
/**
* Start the resource manager and grant leadership to it.
*/
- public void startResourceManager() throws Exception {
+ void startResourceManager() throws Exception {
resourceManager.start();
rmServices.grantLeadership();
}
/**
* Stop the Akka actor system.
*/
- public void stopResourceManager() throws Exception {
+ void stopResourceManager() throws Exception {
rpcService.stopService().get();
}
}
+ static class TestingContainer extends Container {
Review comment:
I am not convinced about this. The mock was introduced with [FLINK-8177](https://issues.apache.org/jira/browse/FLINK-8177) because Hadoop 2.9 added new methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services