You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/31 10:32:46 UTC

[GitHub] [flink] AHeise commented on a change in pull request #10542: [FLINK-12484][runtime] move checkpoint lock to source task

AHeise commented on a change in pull request #10542: [FLINK-12484][runtime] move checkpoint lock to source task
URL: https://github.com/apache/flink/pull/10542#discussion_r373409406
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -154,11 +154,9 @@
 	 * to ensure that we don't have concurrent method calls that void consistent checkpoints.
 	 * <p>CheckpointLock is superseded by {@link MailboxExecutor}, with
 	 * {@link StreamTaskActionExecutor.SynchronizedStreamTaskActionExecutor SynchronizedStreamTaskActionExecutor}
-	 * to provide lock to {@link SourceStreamTask} (will be pushed down later). </p>
-	 * {@link StreamTaskActionExecutor.SynchronizedStreamTaskActionExecutor SynchronizedStreamTaskActionExecutor}
-	 * will be replaced <b>here</b> with {@link StreamTaskActionExecutor} once {@link #getCheckpointLock()} pushed down to {@link SourceStreamTask}.
+	 * to provide lock to {@link SourceStreamTask}. </p>
 	 */
-	private final StreamTaskActionExecutor.SynchronizedStreamTaskActionExecutor actionExecutor;
+	protected final StreamTaskActionExecutor actionExecutor;
 
 Review comment:
   Why is it protected now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services