[GitHub] [geode-native] gaussianrecurrence commented on a change in pull request #806: GEODE-9268: Fix PdxInstance handling after cluster restart

[GitBox <gi...@apache.org>]

gaussianrecurrence commented on a change in pull request #806:
URL: https://github.com/apache/geode-native/pull/806#discussion_r662145861



##########
File path: cppcache/integration/test/PdxSerializerTest.cpp
##########
@@ -115,18 +113,19 @@ std::shared_ptr<Region> setupRegion(Cache& cache) {
   return region;
 }
 
-void assertNonPdxType(const std::shared_ptr<NonPdxType>& expected,
-                      const std::shared_ptr<Cacheable>& actual) {
-  ASSERT_NE(nullptr, actual);
-  auto pdxWrapper = std::dynamic_pointer_cast<PdxWrapper>(actual);
-  ASSERT_NE(nullptr, pdxWrapper);
-  auto object = pdxWrapper->getObject();
-  ASSERT_NE(nullptr, object);
+void expectNonPdxTypeEquals(const std::shared_ptr<NonPdxType>& expected,
+                            const std::shared_ptr<Cacheable>& actual) {
+  EXPECT_TRUE(actual);
+
+  auto wrapper = std::dynamic_pointer_cast<PdxWrapper>(actual);
+  EXPECT_TRUE(wrapper);
+
+  auto object = wrapper->getObject();
+  EXPECT_TRUE(object);
+
   auto nonPdxType = std::static_pointer_cast<NonPdxType>(object);
-  ASSERT_NE(nullptr, nonPdxType);
-  EXPECT_EQ(2, nonPdxType->getLongValue());
+  EXPECT_TRUE(nonPdxType);
 
-  EXPECT_NE(expected, nonPdxType);
   EXPECT_EQ(*expected, *nonPdxType);

Review comment:
       That's odd, I've used EXPECT_EQ lots of times with std::string. The way EXPECT_EQ internally works is by calling operator== and if the comparison fails, then  both objects are serialized and shown the expected and actual in the output. Problem is whenever there is no serialization possible for a pair of objects you are comparing. In this case you would see an hexdump of the objects that can't be serialized.
   
   Serialization btw is done by calling the ostream& operator<<(ostream& os, const ClassName& dt), so internally gtest uses SFINAE to check whether there is or not an implementation for the specific object being serialized.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org