[kudu] 02/02: hms: clarify message to pass in --hive_metastore_uris

[ha...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hahao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 13fdac8e55e635d049d2a0c3a0232d229e630da8
Author: Andrew Wong <aw...@apache.org>
AuthorDate: Mon Jun 10 14:56:05 2019 -0700

    hms: clarify message to pass in --hive_metastore_uris
    
    The error when running the `kudu hms` with no --hive_metastore_uris flag
    did not indicate clearly what the user should do (i.e. pass in the
    flag). This adds that clarity.
    
    Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
    Reviewed-on: http://gerrit.cloudera.org:8080/13578
    Tested-by: Kudu Jenkins
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
 src/kudu/tools/kudu-tool-test.cc  | 6 ++++--
 src/kudu/tools/tool_action_hms.cc | 5 ++++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/kudu/tools/kudu-tool-test.cc b/src/kudu/tools/kudu-tool-test.cc
index a1beeeb..8761522 100644
--- a/src/kudu/tools/kudu-tool-test.cc
+++ b/src/kudu/tools/kudu-tool-test.cc
@@ -4020,8 +4020,10 @@ TEST_F(ToolTest, TestHmsList) {
   string err;
   RunActionStderrString(Substitute("hms list $0", master_addr), &err);
   ASSERT_STR_CONTAINS(err,
-      "Configuration error: the Kudu leader master is not configured with "
-      "the Hive Metastore integration");
+      "Configuration error: Could not fetch the Hive Metastore locations from "
+      "the Kudu master since it is not configured with the Hive Metastore "
+      "integration. Run the tool with --hive_metastore_uris and pass in the "
+      "location(s) of the Hive Metastore.");
 
   // Enable the HMS integration.
   cluster_->ShutdownNodes(cluster::ClusterNodes::MASTERS_ONLY);
diff --git a/src/kudu/tools/tool_action_hms.cc b/src/kudu/tools/tool_action_hms.cc
index 1da8e74..201d031 100644
--- a/src/kudu/tools/tool_action_hms.cc
+++ b/src/kudu/tools/tool_action_hms.cc
@@ -131,7 +131,10 @@ Status Init(const RunnerContext& context,
     string hive_metastore_uris = (*kudu_client)->GetHiveMetastoreUris();
     if (hive_metastore_uris.empty()) {
       return Status::ConfigurationError(
-          "the Kudu leader master is not configured with the Hive Metastore integration");
+          "Could not fetch the Hive Metastore locations from the Kudu master "
+          "since it is not configured with the Hive Metastore integration. "
+          "Run the tool with --hive_metastore_uris and pass in the location(s) "
+          "of the Hive Metastore.");
     }
     bool hive_metastore_sasl_enabled = (*kudu_client)->GetHiveMetastoreSaslEnabled();