You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DmytroShkvyra <gi...@git.apache.org> on 2017/02/15 17:22:10 UTC
[GitHub] zeppelin pull request #2024: [ZEPPELIN-411] JDK8 support
GitHub user DmytroShkvyra opened a pull request:
https://github.com/apache/zeppelin/pull/2024
[ZEPPELIN-411] JDK8 support
### What is this PR for?
Build, test and run with JDK8
### What type of PR is it?
Improvement and Documentation
### Todos
N/A
### What is the Jira issue?
[ZEPPELIN-411]
### How should this be tested?
Travis, test with maven:
export MAVEN_OPTS="-Xmx2g -XX:MaxMetaspaceSize=1024m" && mvn clean verify -Drat.skip=true
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? - No
* Is there breaking changes for older versions? - Older versions can run with JDK8
* Does this needs documentation? - Documentation updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DmytroShkvyra/zeppelin ZEPPELIN-411
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2024.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2024
----
commit d1e93dc32a05f165248de3ce6ec4d0c9ba904a25
Author: DmytroShkvyra <ds...@gmail.com>
Date: 2017-02-15T16:52:43Z
[ZEPPELIN-411] JDK8 support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2024: [ZEPPELIN-411] JDK8 support
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2024
I'm not sure who think what now, I just let you know the history. If you really want to move JDK8, open discussion and reach a "consensus" with community first. I think moving to JDK8 doesn't have any technical hurdle but needs to do it with Apache way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2024: [ZEPPELIN-411] JDK8 support
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2024
You don't have to do it because we eventually will move to further JDK version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2024: [ZEPPELIN-411] JDK8 support
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/zeppelin/pull/2024
Could anybody who has write access merge .travis.yml ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2024: [ZEPPELIN-411] JDK8 support
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/zeppelin/pull/2024
@jongyoul May be make sense just create PR only for try moving to JDK8 and test this with Travis? Anyway nobody will not merge it to zeppelin without approve.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2024: [ZEPPELIN-411] JDK8 support
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra closed the pull request at:
https://github.com/apache/zeppelin/pull/2024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2024: [ZEPPELIN-411] JDK8 support
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2024
And concerning your contribution, we discussed it before and concluded it's too early to move JDK8. If you think it's right time to move on, please start discussion again in dev@ and user@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2024: [ZEPPELIN-411] JDK8 support
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2024
In case that you encounter conflicts, you have to rebase your changes onto the base branch you start working on. AFAIK, ASF doesn't allow write permission through Github.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2024: [ZEPPELIN-411] JDK8 support
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/zeppelin/pull/2024
@jongyoul Should I close ZEPPELIN-411 as "wont fix"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---