You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/12 09:55:05 UTC

[GitHub] [inlong] lucaspeng12138 commented on a diff in pull request #5010: [INLONG-5009][Docker] Fix dataproxy-docker script judgement

lucaspeng12138 commented on code in PR #5010:
URL: https://github.com/apache/inlong/pull/5010#discussion_r918778995


##########
inlong-dataproxy/dataproxy-docker/dataproxy-docker.sh:
##########
@@ -24,10 +24,10 @@ sed -i "s/manager.hosts=.*$/manager.hosts=${MANAGER_OPENAPI_IP}:${MANAGER_OPENAP
 sed -i "s/audit.proxys=.*$/audit.proxys=${AUDIT_PROXY_URL}/g" "${common_conf_file}"
 
 # start
-if [ $MQ_TYPE == "pulsar" ]; then
+if [ "${MQ_TYPE}" = "pulsar" ]; then

Review Comment:
   yes, I tested
   <img width="795" alt="WeChatWorkScreenshot_a9d6ee64-89a3-45ad-a388-4dc450b93baa" src="https://user-images.githubusercontent.com/100204617/178463890-bc97b25e-8d0e-4cf1-a5d8-96b563f71770.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org