You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "devabhishekpal (via GitHub)" <gi...@apache.org> on 2024/08/26 12:03:24 UTC
[PR] HDDS-11368. Remove dependency on Babel in Vite [ozone]
devabhishekpal opened a new pull request, #7119:
URL: https://github.com/apache/ozone/pull/7119
## What changes were proposed in this pull request?
Remove dependency on Babel in Vite
Please describe your PR in detail:
* Babel currently uses caniuse-lite as a transitive dependency and it cannot be included in Apache projects
* Recon is already using Vite for builds, but has Babel usage due to the plugin-react, and svgr plugins.
* This PR uses plugin-react-swc to use SWC instead of Babel for transpilation, and removed dependency on SVGR plugin as we are manually exporting SVG icons as React componets.
* There are no Babel plugins currently being used for transpilation, hence the switch from Babel to SWC is also a simple replacement
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11368
## How was this patch tested?
Patch was tested manually, as well as by running the initial unit tests added to verify no features are broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11368. Remove dependency on Babel in Vite [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #7119:
URL: https://github.com/apache/ozone/pull/7119#issuecomment-2315580107
Thanks @devabhishekpal for tackling the license issue and @devmadhuu for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11368. Remove dependency on Babel in Vite [ozone]
Posted by "devabhishekpal (via GitHub)" <gi...@apache.org>.
devabhishekpal commented on PR #7119:
URL: https://github.com/apache/ozone/pull/7119#issuecomment-2310045702
**For reviewers make sure the following are cross-checked**
- No SVG icons are broken
- Running `pnpm why caniuse-lite` doesn't give any results, meaning caniuse-lite is removed from the project as a dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11368. Remove dependency on Babel in Vite [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #7119:
URL: https://github.com/apache/ozone/pull/7119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11368. Remove dependency on Babel in Vite [ozone]
Posted by "devabhishekpal (via GitHub)" <gi...@apache.org>.
devabhishekpal commented on PR #7119:
URL: https://github.com/apache/ozone/pull/7119#issuecomment-2310052849
@smitajoshi12 could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11368. Remove dependency on Babel in Vite [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #7119:
URL: https://github.com/apache/ozone/pull/7119#issuecomment-2310161936
It looks good to me Can you add screenshot of pnpm why caniuse-lite or other transitive dependency license check command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org