You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/10/16 10:24:47 UTC

[GitHub] [kafka] aglicacha commented on a diff in pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

aglicacha commented on code in PR #12729:
URL: https://github.com/apache/kafka/pull/12729#discussion_r996422546


##########
core/src/main/scala/kafka/zk/AdminZkClient.scala:
##########
@@ -365,6 +365,29 @@ class AdminZkClient(zkClient: KafkaZkClient) extends Logging {
       case ConfigType.Ip => changeIpConfig(entityName, configs)
       case _ => throw new IllegalArgumentException(s"$entityType is not a known entityType. Should be one of ${ConfigType.all}")
     }
+

Review Comment:
   Agree with that. I have moved the clean logic to method changeEntityConfig before zk notification is triggered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org