[GitHub] [geode] dschneider-pivotal opened pull request #2905: GEODE-6068: undo create jdbc-mapping on destroy jdbc-mapping

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

All the jdbc changes done by create jdbc-mapping are now undone by
destroy jdbc-mapping.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2905: GEODE-6068: undo create jdbc-mapping on destroy jdbc-mapping

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

create jdbc-mapping always creates a unique queue for each region. It is 1-to-1. It does not support sharing a single queue on multiple regions.

[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2905: GEODE-6068: undo create jdbc-mapping on destroy jdbc-mapping

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

In that case we set this attribute to the empty string which means it has no asyncQueueIds. We have a unit test that confirms this. So I don't see any need to check for an empty queue here. The String.join call handles it correctly.

[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal closed pull request #2905: GEODE-6068: undo create jdbc-mapping on destroy jdbc-mapping

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by dschneider-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #2905: GEODE-6068: undo create jdbc-mapping on destroy jdbc-mapping

["agingade (GitHub)" <gi...@apache.org>]

It looks like we will be setting empty string ("") as asyncId, if the queue becomes empty after removal, do we need a check for empty queue here.

[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #2905: GEODE-6068: undo create jdbc-mapping on destroy jdbc-mapping

["agingade (GitHub)" <gi...@apache.org>]

Multiple regions can be configured to have same AsyncEventQueue; Not sure if jdbc connector allows multiple regions to have the same async queue; if it allows, it will be good to have tests that  make sure the event queue mapping is removed from only the expected region.

[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org