You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/24 05:29:32 UTC

[GitHub] [pulsar] codecov-commenter commented on pull request #20377: [improve][doc] Remove javadoc reference to old default 30s ack timeout impl

codecov-commenter commented on PR #20377:
URL: https://github.com/apache/pulsar/pull/20377#issuecomment-1560478606

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#20377](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (535cc35) into [master](https://app.codecov.io/gh/apache/pulsar/commit/f20dc93bc7d3defcc824857a558f2f78726f13a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f20dc93) will **increase** coverage by `47.81%`.
   > The diff coverage is `88.34%`.
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/20377/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #20377       +/-   ##
   =============================================
   + Coverage     25.11%   72.93%   +47.81%     
   - Complexity      205    31894    +31689     
   =============================================
     Files          1680     1864      +184     
     Lines        127176   138384    +11208     
     Branches      13863    15183     +1320     
   =============================================
   + Hits          31942   100931    +68989     
   + Misses        90242    29446    -60796     
   - Partials       4992     8007     +3015     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `24.17% <29.12%> (?)` | |
   | systests | `24.96% <21.35%> (-0.15%)` | :arrow_down: |
   | unittests | `72.23% <88.34%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...r/service/SystemTopicTxnBufferSnapshotService.java](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1N5c3RlbVRvcGljVHhuQnVmZmVyU25hcHNob3RTZXJ2aWNlLmphdmE=) | `83.01% <78.94%> (+83.01%)` | :arrow_up: |
   | [...r/impl/SnapshotSegmentAbortedTxnProcessorImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9idWZmZXIvaW1wbC9TbmFwc2hvdFNlZ21lbnRBYm9ydGVkVHhuUHJvY2Vzc29ySW1wbC5qYXZh) | `77.34% <88.23%> (+77.34%)` | :arrow_up: |
   | [...r/metadata/coordination/impl/ResourceLockImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvY29vcmRpbmF0aW9uL2ltcGwvUmVzb3VyY2VMb2NrSW1wbC5qYXZh) | `78.87% <91.30%> (+45.33%)` | :arrow_up: |
   | [...er/impl/SingleSnapshotAbortedTxnProcessorImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9idWZmZXIvaW1wbC9TaW5nbGVTbmFwc2hvdEFib3J0ZWRUeG5Qcm9jZXNzb3JJbXBsLmphdmE=) | `80.61% <100.00%> (+80.61%)` | :arrow_up: |
   | [...java/org/apache/pulsar/common/util/FutureUtil.java](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi91dGlsL0Z1dHVyZVV0aWwuamF2YQ==) | `82.40% <100.00%> (+60.18%)` | :arrow_up: |
   | [...rg/apache/pulsar/common/util/URIPreconditions.java](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi91dGlsL1VSSVByZWNvbmRpdGlvbnMuamF2YQ==) | `83.33% <100.00%> (+83.33%)` | :arrow_up: |
   | [...ar/metadata/coordination/impl/LockManagerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvY29vcmRpbmF0aW9uL2ltcGwvTG9ja01hbmFnZXJJbXBsLmphdmE=) | `89.47% <100.00%> (+31.57%)` | :arrow_up: |
   
   ... and [1540 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20377/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org