You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/08/27 23:08:58 UTC
[GitHub] [ignite] Vladsz83 opened a new pull request #8194: Transaction to the discovery test.
Vladsz83 opened a new pull request #8194:
URL: https://github.com/apache/ignite/pull/8194
+ Transaction to the discovery test.
+ some preparations for next parametrization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on a change in pull request #8194: Transaction to the discovery test.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on a change in pull request #8194:
URL: https://github.com/apache/ignite/pull/8194#discussion_r482036270
##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -61,16 +62,19 @@ class DiscoveryTest(IgniteTest):
FAILURE_DETECTION_TIMEOUT = 2000
- DATA_AMOUNT = 100000
+ DATA_AMOUNT = 5_000_000
+
+ WARMUP_DATA_AMOUNT = 10_000
@cluster(num_nodes=NUM_NODES)
@matrix(version=[str(DEV_BRANCH), str(LATEST_2_8)],
kill_coordinator=[False, True],
nodes_to_kill=[1, 2],
- with_load=[False, True])
+ with_load=[0, 1, 2])
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on a change in pull request #8194: Transaction to the discovery test.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on a change in pull request #8194:
URL: https://github.com/apache/ignite/pull/8194#discussion_r483478981
##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -38,14 +40,23 @@
from ignitetest.utils.version import DEV_BRANCH, LATEST_2_8, IgniteVersion
+class ClusterLoad(IntEnum):
+ """
+ Type of cluster loading.
+ """
+ no_load = 0
+ with_load = 1
+ transactional = 2
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8194: Transaction to the discovery test.
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #8194:
URL: https://github.com/apache/ignite/pull/8194#discussion_r483463818
##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -38,14 +40,23 @@
from ignitetest.utils.version import DEV_BRANCH, LATEST_2_8, IgniteVersion
+class ClusterLoad(IntEnum):
+ """
+ Type of cluster loading.
+ """
+ no_load = 0
+ with_load = 1
+ transactional = 2
Review comment:
transactional_load
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a change in pull request #8194: Transaction to the discovery test.
Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #8194:
URL: https://github.com/apache/ignite/pull/8194#discussion_r481789648
##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -61,16 +62,19 @@ class DiscoveryTest(IgniteTest):
FAILURE_DETECTION_TIMEOUT = 2000
- DATA_AMOUNT = 100000
+ DATA_AMOUNT = 5_000_000
+
+ WARMUP_DATA_AMOUNT = 10_000
@cluster(num_nodes=NUM_NODES)
@matrix(version=[str(DEV_BRANCH), str(LATEST_2_8)],
kill_coordinator=[False, True],
nodes_to_kill=[1, 2],
- with_load=[False, True])
+ with_load=[0, 1, 2])
Review comment:
Use enum here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov merged pull request #8194: Transaction to the discovery test.
Posted by GitBox <gi...@apache.org>.
anton-vinogradov merged pull request #8194:
URL: https://github.com/apache/ignite/pull/8194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org