You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "PHILO-HE (via GitHub)" <gi...@apache.org> on 2025/09/22 04:00:28 UTC

Re: [PR] [GLUTEN-10632][FLINK] Add nexmark test for q11, q12 and q22 [incubator-gluten]

PHILO-HE commented on code in PR #10735:
URL: https://github.com/apache/incubator-gluten/pull/10735#discussion_r2366665880


##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/NexmarkTest.java:
##########
@@ -123,17 +123,20 @@ private void executeQuery(StreamTableEnvironment tEnv, String queryFileName)
     String[] sqlStatements = queryContent.split(";");
     assertThat(sqlStatements.length).isGreaterThanOrEqualTo(2);
 
-    String createResultTable = sqlStatements[0].trim();
-    if (!createResultTable.isEmpty()) {
-      TableResult createResult = tEnv.executeSql(createResultTable);
-      assertFalse(createResult.getJobClient().isPresent());
+    for (int i = 0; i < sqlStatements.length - 2; i++) {

Review Comment:
   Could you explain why we need a loop here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org