You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ariatosca.apache.org by mxmrlv <gi...@git.apache.org> on 2017/06/27 20:07:26 UTC
[GitHub] incubator-ariatosca pull request #166: ARIA-294 workflow tasks execution is ...
GitHub user mxmrlv opened a pull request:
https://github.com/apache/incubator-ariatosca/pull/166
ARIA-294 workflow tasks execution is not in order
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-ariatosca ARIA-294-Workflow-tasks-execution-is-not-in-order
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-ariatosca/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit 8f59335866c71de4c392c4697e927571d11b2be9
Author: max-orlov <ma...@gigaspaces.com>
Date: 2017-06-27T17:32:08Z
wip
commit defd5acf9e74c768f24253e3e5137bb70019dbc2
Author: max-orlov <ma...@gigaspaces.com>
Date: 2017-06-27T20:04:18Z
improved translation test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #166: ARIA-294 workflow tasks execution is ...
Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/166#discussion_r124483622
--- Diff: aria/modeling/orchestration.py ---
@@ -397,13 +397,8 @@ def retry(message=None, retry_interval=None):
raise TaskRetryException(message, retry_interval=retry_interval)
@declared_attr
- def dependency_fk(self):
- return relationship.foreign_key('task', nullable=True)
-
- @declared_attr
def dependencies(cls):
- # symmetric relationship causes funky graphs
- return relationship.one_to_many_self(cls, 'dependency_fk')
+ return relationship.many_to_many(cls, 'task', self=True)
--- End diff --
no need for other model if self=true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #166: ARIA-294 workflow tasks execution is ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-ariatosca/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #166: ARIA-294 workflow tasks execution is not in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/166
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---