You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/15 03:31:48 UTC
[GitHub] [dubbo-go] jack15083 commented on a change in pull request #1157: Fix:delete a service provider when using k8s hpa (3.0)
jack15083 commented on a change in pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157#discussion_r613732638
##########
File path: common/url.go
##########
@@ -344,6 +344,16 @@ func (c *URL) Key() string {
return buildString
}
+//CacheInvokerMapKey get dir cacheInvokerMap key
+func (c *URL) CacheInvokerMapKey() string {
+ urlNew, _ := NewURL(c.PrimitiveURL)
Review comment:
这里加上这一段只是为了获取通知里timestamp，因为这里的c用的旧的invoker url，看下图的逻辑，执行了common.MergeURL(url, referenceUrl) 会将新url的参数给覆盖掉，不清楚为啥要执行这一步merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org