You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/08/14 03:12:36 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
shenyu0127 opened a new pull request, #11339:
URL: https://github.com/apache/pinot/pull/11339
This is a follow-up cleanup for https://github.com/apache/pinot/pull/11328.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11339:
URL: https://github.com/apache/pinot/pull/11339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #11339:
URL: https://github.com/apache/pinot/pull/11339#issuecomment-1676858686
> If somehow people deploy server first
Is this possible? I thought the deployment order was always controller -> broker -> server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #11339:
URL: https://github.com/apache/pinot/pull/11339#issuecomment-1731988744
@Jackie-Jiang please merge the PR whenever you think is right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11339:
URL: https://github.com/apache/pinot/pull/11339#issuecomment-1676631656
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11339](https://app.codecov.io/gh/apache/pinot/pull/11339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (03ca6f7) into [master](https://app.codecov.io/gh/apache/pinot/commit/f25f3ed1f242513b90207d082fb80dbfdc9b06f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f25f3ed) will **decrease** coverage by `53.82%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11339 +/- ##
=============================================
- Coverage 68.46% 14.65% -53.82%
+ Complexity 6535 494 -6041
=============================================
Files 2233 2159 -74
Lines 119952 116775 -3177
Branches 18191 17738 -453
=============================================
- Hits 82128 17111 -65017
- Misses 31984 98250 +66266
+ Partials 5840 1414 -4426
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| java-11 | `?` | |
| java-17 | `14.65% <ø> (-53.66%)` | :arrow_down: |
| java-20 | `14.65% <ø> (-53.65%)` | :arrow_down: |
| temurin | `14.65% <ø> (-53.82%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `14.65% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ator/transform/function/CaseTransformFunction.java](https://app.codecov.io/gh/apache/pinot/pull/11339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzZVRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-38.76%)` | :arrow_down: |
... and [1709 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11339/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #11339:
URL: https://github.com/apache/pinot/pull/11339#issuecomment-1676879895
Yes, it is safe to only include the broker side change in the next release and check in this PR after next release.
Converted the PR to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #11339:
URL: https://github.com/apache/pinot/pull/11339#issuecomment-1676797217
Let's not clean it up now. Broker side is just upgraded. If somehow people deploy server first, this query will fail. Let's wait until next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #11339: Clean up CaseTransformFunction::constructStatementListLegacy.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #11339:
URL: https://github.com/apache/pinot/pull/11339#issuecomment-1676869189
@shenyu0127 Ideally user should not do that, but it would be good to leave longer migration window. Currently broker is still running the old format, so it is safer for server to support both for a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org