You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/03 20:53:52 UTC
[GitHub] [beam] reuvenlax commented on a change in pull request #11259: Use
attachValues in SQL
reuvenlax commented on a change in pull request #11259: Use attachValues in SQL
URL: https://github.com/apache/beam/pull/11259#discussion_r403328568
##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java
##########
@@ -343,7 +351,11 @@ public void processElement(
fieldValues.add(windowStartFieldIndex, ((IntervalWindow) window).start());
}
- o.output(Row.withSchema(outputSchema).addValues(fieldValues).build());
+ Row row =
+ verifyRowValues
+ ? Row.withSchema(outputSchema).addValues(fieldValues).build()
+ : Row.withSchema(outputSchema).attachValues(fieldValues);
Review comment:
pr/10883 changed attachValues() to return a Row, so build() not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services