You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/11/17 17:05:29 UTC
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/
-----------------------------------------------------------
(Updated Nov. 17, 2016, 5:05 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Summary (updated)
-----------------
[ATLAS-1304] Redundant code removal and code simplification
Bugs: ATLAS-1304
https://issues.apache.org/jira/browse/ATLAS-1304
Repository: atlas
Description
-------
Redundant code removal and code simplification
Diffs
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0940f2cec7d081369ce0869fa16448189
addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a68e0eeb00f6134f1c5bed092d0b0f2a71
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4201f2d971f1ae6da3b473d5fd91506f8
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cc83c08422bde0177018a31114d43dd7466a5ca9
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7240145dc476eb1a16b1670b24e543c64
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe4d81cbeeb28c7398c37f420d63a73f24
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea24114291479fe172bccd916e7d5b8c9e
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe3861266f52b3fe437581d703a91d8b7d9
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4c31a7c32b00ed0e32f037540f88d7078
authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd52a40c97f889e289127ae2b509f08aa5
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040e9b2c38f99c2ec155a9522bb1dcd3efb
authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403cdd4e95c8b46501b8c6ce9418155054c
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 9327f637033ec6ca647c829bad7052a2bcbda232
authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491ccec18563e95aa9231df5a0c2cca0bb3
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe8159873ac72b3352c497609b2ad3feb46ab6f9
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e7db05524de7071d237cac91a52caaf30
authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78cb2eb8372a54e69a99d8c27e73b1d868
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7052b30261e8f6b95eca1c837de854776
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e1aedbf0295b6e9dc6bf596bc06f867b4
authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea3c034fcb1f76bc4c00853f38bca2bc91
catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6b35c2da29802260533b2fe619e15d102
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61156786bb1a4f93b7753cb14f51b85f72
catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c80b1f350552bc162d1ca256b24c8e300
catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc6dd1fb50a39dbadcb023774c2271b808
catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c391c85b0a7cdb9cf859cca81d85fac0d
catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e491995abfa18e83b93266f8a53458750e
client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213baaf118c5fa9c87636547a09b5e119745
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826ece8c1cda42f42bd63c6ec29d6f827244
client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891106e118766418cc5e8fe80a3d5f2d868
common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef998b4c8361b4f194539577014428483db
common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55bc856ac980587bc3d01bcad986de6320
common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f49c5bc1d770d755449e261aa90bd38b0b
common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c4394b4e863672af9dea7611792d70170c0
dashboardv2/public/js/views/tag/addTagModalView.js 972997cccce415360308c4b81d3d698eb0a194f4
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c6781d6fca2ad715ce0bb82ee886bbfc8a96
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d663530177def98249139adacdffefbea2
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6ce9bd149d493ba0073b444ff701fea7b
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b97532fb29dc0f6d1c810e63076be0a291ab
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5ea391cf976a82bd6f50d2a5ab74caed3d
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40e20951f842100104442b6258170c2f1e
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aadcfbc1b18d75c874ac30c7cffc3cfc73a
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5bff55bc98ea4807f1e28ae8f895226a1
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8bf46ff086ef2b796250fabee5054a1c6
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47dbbd6cad6a805094aec3fa5758ccc96f
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1ae0c565576c38131674021db613598daf
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java 3b5620ce2e9edc8d54168703fff87c45e4dff1f0
graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8dbf02c0d26a3b41c4f871eede97bf2823
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 2dbe742202d218c20223b05eac6b166d8e993a6c
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78db71744f2e4869cd9348189952d0c84a4
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca0441513ab9a68010b7e0c94900bf9e30845ec
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae70791b2adbfd1c8d5312ee1545a4b889a
graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401ad2fd9f8cd97733c50865c64d03ff11ef
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c71aa012585f9e5fd475d618a3c616c733
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487340104651d0f69cbb97b4a93badae93d
intg/src/main/java/org/apache/atlas/model/SearchFilter.java 64800a5aa91e05f9b874feaeb3a18b0393904382
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf7cb034bd37fd63c4bdb1539a661c6d914
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74aebdbf2b47125f98884ce105873c7763601
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585ca3721c77adc6ee65ba67af6d1845051b
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bbf2c36005409d55d0b57b1f5ca512a5873
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187d84f19bc867f45d277fb87f5c930e2b5
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f3364235e81f6eee4d9600bb63ef5e682142
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d9536335b74733aaff6e4bff77decbdcaa1cb6bb
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e3412789c26779aeff71d6fda5833f7c515f336
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e23881b1307c2fdd51add9749257f64838d3b0
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b2ec16cbbbea991b4d7dd32d8a019e8ff4
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b0955d8d8878a9c7acc3ed0377d12c48c98c7
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 156ed4315b3cac26fe54515be985870f1993864a
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073cbcbfb885d60c15158fe2492017090516
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e9bfc6a04a503e9e7dc7e6403385acda5
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4ec66179cbc49c82acc089aea0103ba77c
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76f8e3f92fb080d2e7d6d88ce22e73127e
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc3e4508ae209f1c22b84189d4d1f941f1
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 534f2a9ea2e3f4a47906ae7f6f70b663af2579a3
intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f0789b234bc8a9813df7fca79ca4d96264e
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f927e922f42d12b8c70d3c2a608b894980
intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104699b48cfafad46e6cbe9c0e83ad26102
intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d4e03e5a73d5ec35ab9fb1803a57687d9
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5fc1ea833d852465537fc6ede98f9ff42
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec0b812545910ae59d498149de1caa1fd8
intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587e35e32b7cf3538abd577f370ee68f9dc
intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f80f10278749a62407dd83b10b22732f16
intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81b1a39d282cb31c89f2e29254eafe7984
intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38de28c7339cef52d813e0cdc25652fae01
intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf66633751f4e664272abbbc954f5c606e
intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de2572365aa5c56f9248801a88403a6986765
intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1dde0975cfb156c4de7c0df794473361f
intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138c5a97fc055882219f16c14b861207b70
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3683ed1d90323058303d06c94ade5e8fe
intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d562d2657acd2de197134bcd282788cb8e
intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415d8fc6148810315ed9d5d6c300894da68
intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb08903da0078f6468a3b700aa453e52f44d0f
intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d54973610f46ce585a632a9949a6f105d299
intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c63698338a1d471e6432ce64bb08f386d
intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e0126bb388cee9f41e43392fb7e99dbf1
intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d98673141924de106f3b7370c3d716607eee
intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java 1a1523295bd1fd6396aae131545c16ca52473f77
notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edecee3fc1560c525422c1b18cf3238d9f1c
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27fc4087796800963b1a8b7921216194e8
repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java c773bac217666f6f430cca4a726143cbe03205f5
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf6773a523f3f078fbf959d7852877bc63
repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java 4d3177c0bb74b5f1a9eb4031f6655e313fc1d8c1
repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca7abbda1adca99c6ca10fa473c4b76913
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java a901b5127b3dcd2939fec2c642475d7aad869d8e
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java 32189bc6dab4cc25748e7b6136dc0a89476012c7
repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d68634363e588b1b517a557d4d4692fd3d
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f23a0760a601404ff38fc9d043b12dce8bd
repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c30797c34a0b24db2a6582476cac25a7b
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c43e05b264e1c63f8caa991863e02b1a12
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54faaee32e00065de5d0aab32bb7f1923f00a
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d3009aec359b89a61e3a037209e62cdcb4bc
repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287f1f041693d7522848eb0f72fd396ee56
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011934dc67169d9e189c018bf79489a713d4
repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f0ff7ab66cf9bbde7f068b2c5a0421f6d
repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb6a76e8c81006f9c27ceb8e8c9d0806c6
repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977ec61c6400030a51be84d8ba773f57615
repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794fac34f8cfd1bcd300bd5bad04f82cb6d
repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be943a2c6a835e230370f23457cbcfa1f1c8
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b3372e1a756189e5915524fd0daecce7c46
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java ffa73e2af43ff394f71973327505a31e7c5e992f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java cb389a9d74d2f2fb0d36bdee253bd9523e4ef956
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 53d659110f5b1b15f7ebfd2400c23df67d8b8598
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee63061629b53aa22b1b82b75ee9d4ceb29a82e7
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2ce2792ee65ea84ee49afd4b3709942378
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b9789d67cb124e7929d495da04878f2ea35d
repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c36214f6c9b596691720c73f81a39f2e04
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1fb3abf8cd2d4abf4429b00c32837ef0c0
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e2035a39611b4acdda199c6fbaf3fa461a3c
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12addb5ba8109703051b0b8d3cbc4e5f10
repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41dfa63e1a0a53299c8a31330756f17a1f
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff75a846f2fcb580ff2696ec92c9a1a077
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62c1b94e884267e454ee7ee5debb2b5f995
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a7cbeb6eefb0dd15b9a3c0c049b6b857b
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a86d1644f4e9eccef152e1c6a57b023d062
typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163ed42ee84f12a0e29929d842a71ae91c52
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf946b70061a7befdcc3222203fb028f88a
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 806942244c2349e64bed0ca78647c6f551c51084
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5827814b745253e0831c5d95bab5a97e3
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f0155724417280cfc6a1d217910b33db3
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d25730764e25a8f4a7c78e408ad3198cd4788e4
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e296850e8db91aa24b51020f5538fecb6
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3465308559646b4a1c2a7271bae65a9f7
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a4b142893ed47db0056dadd24827c637b
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca9b57c60781a2090da0fa5ff3846ba623
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aac27ec8a70916a08da8dfeaf3f60b9f12
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b352648366222d89c0a5baffeb66843652822a
typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3e3babd1c579417a964abffd2e8cfb083
typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd4aae240148e176dc1eaeb191ec1257d2
typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf95d0a41ee4ebf789c5558fa39c60ba08
typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae96af576c6f26266ada90ebedd8183dd9
typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3645df54941116384f170642d9606b14c
typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b822d8e20ccf894d535dada35390e126f7
webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855eb884289ad2dacd05ab8864447ee9b365
webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java 70b24820559cfc13013563f20b314b364dd71f5b
webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java a14f939274f42dab47e03a2db55fb9e0f67f2dd5
webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff800036bc9bd4b5d19ef449ce940eeca3aa475
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 30200b5535b04c4025ddc7594a90057c6ddb0149
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd730a256f53a7e9d29421010f029b3bcc51
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c578067b3a9f62704c45971054f14866956
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 4b45927fb10e9774e6cdd109bec8dae18362e7b5
webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578d224de982460565d3dede4135513ae1f
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java 595387aec48bbcd369c4610a630956974ee16820
webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de84420a321324ed29f15159049775d2e1558
webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c968d6bdda0a6eed341873856ebf8d046
webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0f867a00b22925c360bf842402111728d
webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd25bf7eb9836ba77fb7a2cfc45e08ab75f
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b81175ada20501659c5bf74a9b84057089
webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de471715554d3fe7dd45e56d517a657b1fa
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892acb133af167d83e39024fd8e2d306c2cf3
webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9baa67abafd36bd3f66e27bfae29f9f53
webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc6386fe4fc1b9e7ad5ab8d12828c09579f05
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java ea86cc689cf6a2950116f64188263ff7515721a3
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f2d2844a39b10ac5a31d883e671907d64
webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc392c2567ffdc133643839c6604d04ef086
webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java f96fa752f7336669d08c8498e420d3627800c9e9
webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf108be564e2c496b17ef69b6fc3c35277
webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121fd556d9ad7a424bcf2fb4419af1f50f34
Diff: https://reviews.apache.org/r/53789/diff/
Testing
-------
Unit Tests passing.
Thanks,
Apoorv Naik
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/#review159389
-----------------------------------------------------------
Fix it, then Ship it!
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 358)
<https://reviews.apache.org/r/53789/#comment230378>
anOldColList ==> oldCol
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 365)
<https://reviews.apache.org/r/53789/#comment230379>
aNewColList ==> newCol
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java (line 177)
<https://reviews.apache.org/r/53789/#comment230380>
Consider using StringUtils.isNotEmpty(valStr)
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java (line 647)
<https://reviews.apache.org/r/53789/#comment230383>
anActualArray ==> referenceable
- Madhan Neethiraj
On Dec. 15, 2016, 10:06 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53789/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 10:06 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1304
> https://issues.apache.org/jira/browse/ATLAS-1304
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Redundant code removal and code simplification
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a6
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cf8851c0
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4
> authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040
> authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java e48c5ae7
> authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 2a6929a6
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e
> authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e
> authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea
> catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6
> catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61
> catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c
> catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc
> catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e4
> client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826e
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891
> common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef9
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55
> common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f4
> common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43
> dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c678
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d6
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b975
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5e
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aad
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1a
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java f3b9fd90
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8d
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 7c8cfe8c
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78d
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca04415
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae7
> graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401a
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c7
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4e4a9e8b
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 0c4de4d2
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 146d3c97
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 41385f52
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45efb04d
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 6119dafc
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java e2d61818
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 70321822
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 480b27b8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 69d7b301
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 4de71799
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 48d0a27e
> intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073c
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4e
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ef5f7364
> intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f07
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f9
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104
> intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec
> intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f8
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81
> intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38d
> intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf
> intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de257
> intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1
> intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3
> intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d5
> intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415
> intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb0890
> intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d549
> intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c
> intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e
> intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d986
> intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java ee05ba36
> notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edec
> plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf
> repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fcf120ab
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 6b689615
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java ca1ad5df
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d6
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java ae1ec45a
> repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 1a3faf77
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9ef31601
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cb54c3e6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d
> repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f
> repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb
> repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977
> repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794
> repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be94
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b33
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 19c87011
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java bef6d18e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java ab3b3d91
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee630616
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2c
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b978
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c3
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java fba6d195
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e203
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 75ec9a24
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 63988293
> typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163e
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf9
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d257307
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aa
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 6f63d0f3
> typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3
> typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae
> typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3
> typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b8
> webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855e
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff80003
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 33070156
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd73
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c57
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java ec5d891f
> webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae
> webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844
> webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c
> webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0
> webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8
> webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4
> webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac
> webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830
> webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f
>
> Diff: https://reviews.apache.org/r/53789/diff/
>
>
> Testing
> -------
>
> Unit Tests passing.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/
-----------------------------------------------------------
(Updated Dec. 16, 2016, 4:41 a.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
Addressed review comments.
Bugs: ATLAS-1304
https://issues.apache.org/jira/browse/ATLAS-1304
Repository: atlas
Description
-------
Redundant code removal and code simplification
Diffs (updated)
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0
addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a6
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cf8851c0
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4
authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040
authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java e48c5ae7
authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 2a6929a6
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e
authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e
authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea
catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61
catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c
catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc
catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c
catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e4
client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826e
client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891
common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef9
common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55
common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f4
common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43
dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c678
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d6
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b975
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5e
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aad
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1a
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java f3b9fd90
graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8d
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 7c8cfe8c
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78d
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca04415
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae7
graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401a
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c7
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487
intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4e4a9e8b
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 0c4de4d2
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 146d3c97
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 41385f52
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45efb04d
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 6119dafc
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java e2d61818
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 70321822
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 480b27b8
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 69d7b301
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 4de71799
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 48d0a27e
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073c
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4e
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ef5f7364
intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f07
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f9
intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104
intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec
intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587
intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f8
intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81
intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38d
intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf
intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de257
intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1
intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3
intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d5
intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415
intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb0890
intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d549
intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c
intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e
intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d986
intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java ee05ba36
notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edec
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf
repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fcf120ab
repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 6b689615
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java ca1ad5df
repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d6
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java ae1ec45a
repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 1a3faf77
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9ef31601
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cb54c3e6
repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d
repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f
repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb
repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977
repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794
repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be94
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b33
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 19c87011
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java bef6d18e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java ab3b3d91
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee630616
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2c
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b978
repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c3
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java fba6d195
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e203
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12
repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 75ec9a24
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 63988293
typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163e
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf9
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d257307
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aa
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 6f63d0f3
typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3
typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd
typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf
typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae
typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3
typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b8
webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855e
webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff80003
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 33070156
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd73
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c57
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java ec5d891f
webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae
webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844
webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c
webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0
webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8
webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac
webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9
webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f
webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39
webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830
webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf
webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f
Diff: https://reviews.apache.org/r/53789/diff/
Testing
-------
Unit Tests passing.
Thanks,
Apoorv Naik
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 10:06 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1304
https://issues.apache.org/jira/browse/ATLAS-1304
Repository: atlas
Description
-------
Redundant code removal and code simplification
Diffs
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0
addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a6
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cf8851c0
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4
authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040
authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java e48c5ae7
authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 2a6929a6
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e
authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e
authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea
catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61
catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c
catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc
catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c
catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e4
client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826e
client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891
common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef9
common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55
common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f4
common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43
dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c678
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d6
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b975
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5e
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aad
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1a
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java f3b9fd90
graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8d
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 7c8cfe8c
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78d
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca04415
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae7
graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401a
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c7
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487
intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4e4a9e8b
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 0c4de4d2
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 146d3c97
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 41385f52
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45efb04d
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 6119dafc
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java e2d61818
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 70321822
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 480b27b8
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 69d7b301
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 4de71799
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 48d0a27e
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073c
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4e
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ef5f7364
intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f07
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f9
intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104
intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec
intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587
intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f8
intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81
intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38d
intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf
intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de257
intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1
intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3
intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d5
intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415
intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb0890
intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d549
intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c
intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e
intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d986
intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java ee05ba36
notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edec
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf
repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fcf120ab
repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 6b689615
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java ca1ad5df
repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d6
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java ae1ec45a
repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 1a3faf77
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9ef31601
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cb54c3e6
repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d
repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f
repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb
repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977
repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794
repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be94
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b33
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 19c87011
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java bef6d18e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java ab3b3d91
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee630616
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2c
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b978
repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c3
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java fba6d195
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e203
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12
repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 75ec9a24
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 63988293
typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163e
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf9
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d257307
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aa
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 6f63d0f3
typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3
typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd
typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf
typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae
typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3
typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b8
webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855e
webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff80003
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 33070156
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd73
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c57
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java ec5d891f
webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae
webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844
webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c
webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0
webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8
webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac
webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9
webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f
webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39
webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830
webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf
webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f
Diff: https://reviews.apache.org/r/53789/diff/
Testing
-------
Unit Tests passing.
Thanks,
Apoorv Naik
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/#review159262
-----------------------------------------------------------
Ship it!
Ship It!
- Vimal Sharma
On Dec. 14, 2016, 8:40 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53789/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 8:40 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1304
> https://issues.apache.org/jira/browse/ATLAS-1304
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Redundant code removal and code simplification
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a6
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cf8851c0
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4
> authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040
> authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java e48c5ae7
> authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 2a6929a6
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e
> authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e
> authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea
> catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6
> catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61
> catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c
> catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc
> catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e4
> client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826e
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891
> common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef9
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55
> common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f4
> common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43
> dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c678
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d6
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b975
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5e
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aad
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1a
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java f3b9fd90
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8d
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 7c8cfe8c
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78d
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca04415
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae7
> graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401a
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c7
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4e4a9e8b
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 0c4de4d2
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 146d3c97
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 41385f52
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45efb04d
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 6119dafc
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java e2d61818
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 70321822
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 480b27b8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 69d7b301
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 4de71799
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 48d0a27e
> intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073c
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4e
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ef5f7364
> intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f07
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f9
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104
> intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec
> intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f8
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81
> intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38d
> intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf
> intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de257
> intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1
> intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3
> intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d5
> intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415
> intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb0890
> intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d549
> intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c
> intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e
> intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d986
> intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java ee05ba36
> notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edec
> plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf
> repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fcf120ab
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 6b689615
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java ca1ad5df
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d6
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java ae1ec45a
> repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 1a3faf77
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9ef31601
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cb54c3e6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d
> repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f
> repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb
> repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977
> repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794
> repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be94
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b33
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 19c87011
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java bef6d18e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java ab3b3d91
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee630616
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2c
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b978
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c3
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java fba6d195
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e203
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 75ec9a24
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 63988293
> typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163e
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf9
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d257307
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aa
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 6f63d0f3
> typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3
> typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae
> typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3
> typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b8
> webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855e
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff80003
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 33070156
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd73
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c57
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java ec5d891f
> webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae
> webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844
> webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c
> webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0
> webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8
> webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4
> webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac
> webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830
> webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f
>
> Diff: https://reviews.apache.org/r/53789/diff/
>
>
> Testing
> -------
>
> Unit Tests passing.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/#review159373
-----------------------------------------------------------
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java (line 100)
<https://reviews.apache.org/r/53789/#comment230356>
This change shouldn't be here. It's a wrong negation expression.
- Apoorv Naik
On Dec. 14, 2016, 8:40 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53789/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 8:40 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1304
> https://issues.apache.org/jira/browse/ATLAS-1304
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Redundant code removal and code simplification
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a6
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cf8851c0
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4
> authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040
> authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java e48c5ae7
> authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 2a6929a6
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e
> authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e
> authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea
> catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6
> catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61
> catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c
> catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc
> catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e4
> client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826e
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891
> common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef9
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55
> common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f4
> common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43
> dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c678
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d6
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b975
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5e
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aad
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1a
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java f3b9fd90
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8d
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 7c8cfe8c
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78d
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca04415
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae7
> graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401a
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c7
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4e4a9e8b
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 0c4de4d2
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 146d3c97
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 41385f52
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45efb04d
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 6119dafc
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java e2d61818
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 70321822
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 480b27b8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 69d7b301
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 4de71799
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 48d0a27e
> intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073c
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4e
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ef5f7364
> intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f07
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f9
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104
> intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec
> intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f8
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81
> intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38d
> intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf
> intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de257
> intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1
> intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3
> intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d5
> intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415
> intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb0890
> intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d549
> intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c
> intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e
> intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d986
> intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java ee05ba36
> notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edec
> plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf
> repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fcf120ab
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 6b689615
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java ca1ad5df
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d6
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java ae1ec45a
> repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 1a3faf77
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9ef31601
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cb54c3e6
> repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d
> repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f
> repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb
> repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977
> repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794
> repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be94
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b33
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 19c87011
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java bef6d18e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java ab3b3d91
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee630616
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2c
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b978
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c3
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java fba6d195
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e203
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 75ec9a24
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 63988293
> typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163e
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf9
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d257307
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aa
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 6f63d0f3
> typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3
> typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae
> typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3
> typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b8
> webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855e
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff80003
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 33070156
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd73
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c57
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java ec5d891f
> webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae
> webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844
> webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c
> webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0
> webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8
> webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4
> webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac
> webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830
> webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f
>
> Diff: https://reviews.apache.org/r/53789/diff/
>
>
> Testing
> -------
>
> Unit Tests passing.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 8:40 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
Rebased and addressed review comments.
Bugs: ATLAS-1304
https://issues.apache.org/jira/browse/ATLAS-1304
Repository: atlas
Description
-------
Redundant code removal and code simplification
Diffs (updated)
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0
addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a6
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cf8851c0
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4
authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040
authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java e48c5ae7
authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 2a6929a6
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e
authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7
authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e
authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea
catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61
catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c
catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc
catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c
catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e4
client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826e
client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891
common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef9
common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55
common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f4
common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43
dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c678
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d6
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b975
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5e
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aad
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1a
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java f3b9fd90
graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8d
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 7c8cfe8c
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78d
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca04415
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae7
graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401a
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c7
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487
intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4e4a9e8b
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 0c4de4d2
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 146d3c97
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 41385f52
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45efb04d
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 6119dafc
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java e2d61818
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 70321822
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 480b27b8
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 69d7b301
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 4de71799
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 48d0a27e
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073c
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4e
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ef5f7364
intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f07
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f9
intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104
intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5
intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec
intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587
intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f8
intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81
intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38d
intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf
intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de257
intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1
intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3
intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d5
intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415
intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb0890
intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d549
intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c
intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e
intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d986
intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java ee05ba36
notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edec
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf
repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fcf120ab
repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 6b689615
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java ca1ad5df
repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d6
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java ae1ec45a
repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 1a3faf77
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9ef31601
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cb54c3e6
repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d
repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f
repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb
repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977
repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794
repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be94
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b33
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 19c87011
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java bef6d18e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java ab3b3d91
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee630616
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2c
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b978
repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c3
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java fba6d195
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e203
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12
repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 75ec9a24
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a
typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 63988293
typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163e
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf9
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5
typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d257307
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aa
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 6f63d0f3
typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3
typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd
typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf
typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae
typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3
typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b8
webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855e
webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff80003
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 33070156
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd73
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c57
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java ec5d891f
webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578
webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30ae
webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844
webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c
webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0
webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8
webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892ac
webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9
webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f
webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39
webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830
webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf
webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121f
Diff: https://reviews.apache.org/r/53789/diff/
Testing
-------
Unit Tests passing.
Thanks,
Apoorv Naik
Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code
simplification
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/#review157272
-----------------------------------------------------------
Ship it!
Please mark previous issues as Fixed or Drop when revising the patch
- Vimal Sharma
On Nov. 17, 2016, 5:05 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53789/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2016, 5:05 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1304
> https://issues.apache.org/jira/browse/ATLAS-1304
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Redundant code removal and code simplification
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0940f2cec7d081369ce0869fa16448189
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a68e0eeb00f6134f1c5bed092d0b0f2a71
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java cbc51cc4201f2d971f1ae6da3b473d5fd91506f8
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cc83c08422bde0177018a31114d43dd7466a5ca9
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java 79a1afe7240145dc476eb1a16b1670b24e543c64
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe4d81cbeeb28c7398c37f420d63a73f24
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0cba27ea24114291479fe172bccd916e7d5b8c9e
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe3861266f52b3fe437581d703a91d8b7d9
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java edd95ba4c31a7c32b00ed0e32f037540f88d7078
> authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd52a40c97f889e289127ae2b509f08aa5
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040e9b2c38f99c2ec155a9522bb1dcd3efb
> authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403cdd4e95c8b46501b8c6ce9418155054c
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 9327f637033ec6ca647c829bad7052a2bcbda232
> authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491ccec18563e95aa9231df5a0c2cca0bb3
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe8159873ac72b3352c497609b2ad3feb46ab6f9
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e7db05524de7071d237cac91a52caaf30
> authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 57156b78cb2eb8372a54e69a99d8c27e73b1d868
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java 453364d7052b30261e8f6b95eca1c837de854776
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e1aedbf0295b6e9dc6bf596bc06f867b4
> authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java 8b27e2ea3c034fcb1f76bc4c00853f38bca2bc91
> catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6b35c2da29802260533b2fe619e15d102
> catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61156786bb1a4f93b7753cb14f51b85f72
> catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c80b1f350552bc162d1ca256b24c8e300
> catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java 47d182cc6dd1fb50a39dbadcb023774c2271b808
> catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c391c85b0a7cdb9cf859cca81d85fac0d
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e491995abfa18e83b93266f8a53458750e
> client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213baaf118c5fa9c87636547a09b5e119745
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826ece8c1cda42f42bd63c6ec29d6f827244
> client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891106e118766418cc5e8fe80a3d5f2d868
> common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef998b4c8361b4f194539577014428483db
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55bc856ac980587bc3d01bcad986de6320
> common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f49c5bc1d770d755449e261aa90bd38b0b
> common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c4394b4e863672af9dea7611792d70170c0
> dashboardv2/public/js/views/tag/addTagModalView.js 972997cccce415360308c4b81d3d698eb0a194f4
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 5d60c6781d6fca2ad715ce0bb82ee886bbfc8a96
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java f2e0f9d663530177def98249139adacdffefbea2
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java 39c309d6ce9bd149d493ba0073b444ff701fea7b
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java c205b97532fb29dc0f6d1c810e63076be0a291ab
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java 46831a5ea391cf976a82bd6f50d2a5ab74caed3d
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java 80033b40e20951f842100104442b6258170c2f1e
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java c9b03aadcfbc1b18d75c874ac30c7cffc3cfc73a
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java 2c0d6fe5bff55bc98ea4807f1e28ae8f895226a1
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java c5f6e0d8bf46ff086ef2b796250fabee5054a1c6
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java a94a7e47dbbd6cad6a805094aec3fa5758ccc96f
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java 20c59e1ae0c565576c38131674021db613598daf
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java 3b5620ce2e9edc8d54168703fff87c45e4dff1f0
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java 89c02c8dbf02c0d26a3b41c4f871eede97bf2823
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 2dbe742202d218c20223b05eac6b166d8e993a6c
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java 7beed78db71744f2e4869cd9348189952d0c84a4
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java 9ca0441513ab9a68010b7e0c94900bf9e30845ec
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 9f9c8ae70791b2adbfd1c8d5312ee1545a4b889a
> graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java d0fd401ad2fd9f8cd97733c50865c64d03ff11ef
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java bf4519c71aa012585f9e5fd475d618a3c616c733
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java e82de487340104651d0f69cbb97b4a93badae93d
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java 64800a5aa91e05f9b874feaeb3a18b0393904382
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf7cb034bd37fd63c4bdb1539a661c6d914
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74aebdbf2b47125f98884ce105873c7763601
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585ca3721c77adc6ee65ba67af6d1845051b
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bbf2c36005409d55d0b57b1f5ca512a5873
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187d84f19bc867f45d277fb87f5c930e2b5
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f3364235e81f6eee4d9600bb63ef5e682142
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d9536335b74733aaff6e4bff77decbdcaa1cb6bb
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e3412789c26779aeff71d6fda5833f7c515f336
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e23881b1307c2fdd51add9749257f64838d3b0
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b2ec16cbbbea991b4d7dd32d8a019e8ff4
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b0955d8d8878a9c7acc3ed0377d12c48c98c7
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 156ed4315b3cac26fe54515be985870f1993864a
> intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073cbcbfb885d60c15158fe2492017090516
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e9bfc6a04a503e9e7dc7e6403385acda5
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4ec66179cbc49c82acc089aea0103ba77c
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76f8e3f92fb080d2e7d6d88ce22e73127e
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc3e4508ae209f1c22b84189d4d1f941f1
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 534f2a9ea2e3f4a47906ae7f6f70b663af2579a3
> intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f0789b234bc8a9813df7fca79ca4d96264e
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f927e922f42d12b8c70d3c2a608b894980
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104699b48cfafad46e6cbe9c0e83ad26102
> intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d4e03e5a73d5ec35ab9fb1803a57687d9
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5fc1ea833d852465537fc6ede98f9ff42
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec0b812545910ae59d498149de1caa1fd8
> intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587e35e32b7cf3538abd577f370ee68f9dc
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f80f10278749a62407dd83b10b22732f16
> intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81b1a39d282cb31c89f2e29254eafe7984
> intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38de28c7339cef52d813e0cdc25652fae01
> intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf66633751f4e664272abbbc954f5c606e
> intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de2572365aa5c56f9248801a88403a6986765
> intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1dde0975cfb156c4de7c0df794473361f
> intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138c5a97fc055882219f16c14b861207b70
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3683ed1d90323058303d06c94ade5e8fe
> intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d562d2657acd2de197134bcd282788cb8e
> intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415d8fc6148810315ed9d5d6c300894da68
> intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb08903da0078f6468a3b700aa453e52f44d0f
> intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d54973610f46ce585a632a9949a6f105d299
> intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c63698338a1d471e6432ce64bb08f386d
> intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e0126bb388cee9f41e43392fb7e99dbf1
> intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d98673141924de106f3b7370c3d716607eee
> intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java 1a1523295bd1fd6396aae131545c16ca52473f77
> notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edecee3fc1560c525422c1b18cf3238d9f1c
> plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java c3ec5e27fc4087796800963b1a8b7921216194e8
> repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java c773bac217666f6f430cca4a726143cbe03205f5
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf6773a523f3f078fbf959d7852877bc63
> repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java 4d3177c0bb74b5f1a9eb4031f6655e313fc1d8c1
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java c0cc25ca7abbda1adca99c6ca10fa473c4b76913
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java a901b5127b3dcd2939fec2c642475d7aad869d8e
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java 32189bc6dab4cc25748e7b6136dc0a89476012c7
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java f2bfc6d68634363e588b1b517a557d4d4692fd3d
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f23a0760a601404ff38fc9d043b12dce8bd
> repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c30797c34a0b24db2a6582476cac25a7b
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 691a12c43e05b264e1c63f8caa991863e02b1a12
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java aea54faaee32e00065de5d0aab32bb7f1923f00a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d3009aec359b89a61e3a037209e62cdcb4bc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java 51d59287f1f041693d7522848eb0f72fd396ee56
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java ceb6011934dc67169d9e189c018bf79489a713d4
> repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f0ff7ab66cf9bbde7f068b2c5a0421f6d
> repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb6a76e8c81006f9c27ceb8e8c9d0806c6
> repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java d7acf977ec61c6400030a51be84d8ba773f57615
> repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794fac34f8cfd1bcd300bd5bad04f82cb6d
> repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java 9351be943a2c6a835e230370f23457cbcfa1f1c8
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java 1ad04b3372e1a756189e5915524fd0daecce7c46
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java ffa73e2af43ff394f71973327505a31e7c5e992f
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java cb389a9d74d2f2fb0d36bdee253bd9523e4ef956
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 53d659110f5b1b15f7ebfd2400c23df67d8b8598
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java ee63061629b53aa22b1b82b75ee9d4ceb29a82e7
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2ce2792ee65ea84ee49afd4b3709942378
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b9789d67cb124e7929d495da04878f2ea35d
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c36214f6c9b596691720c73f81a39f2e04
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 645fef1fb3abf8cd2d4abf4429b00c32837ef0c0
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java 7ae5e2035a39611b4acdda199c6fbaf3fa461a3c
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java dbd4bf12addb5ba8109703051b0b8d3cbc4e5f10
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 000f2f41dfa63e1a0a53299c8a31330756f17a1f
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff75a846f2fcb580ff2696ec92c9a1a077
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 561cb62c1b94e884267e454ee7ee5debb2b5f995
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 6fb2087a7cbeb6eefb0dd15b9a3c0c049b6b857b
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a86d1644f4e9eccef152e1c6a57b023d062
> typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163ed42ee84f12a0e29929d842a71ae91c52
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf946b70061a7befdcc3222203fb028f88a
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 806942244c2349e64bed0ca78647c6f551c51084
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java a8f2eeb5827814b745253e0831c5d95bab5a97e3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f0155724417280cfc6a1d217910b33db3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d25730764e25a8f4a7c78e408ad3198cd4788e4
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e296850e8db91aa24b51020f5538fecb6
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java b97669a3465308559646b4a1c2a7271bae65a9f7
> typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a4b142893ed47db0056dadd24827c637b
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala df1851ca9b57c60781a2090da0fa5ff3846ba623
> typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aac27ec8a70916a08da8dfeaf3f60b9f12
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala 73b352648366222d89c0a5baffeb66843652822a
> typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a3e3babd1c579417a964abffd2e8cfb083
> typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd4aae240148e176dc1eaeb191ec1257d2
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf95d0a41ee4ebf789c5558fa39c60ba08
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae96af576c6f26266ada90ebedd8183dd9
> typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3645df54941116384f170642d9606b14c
> typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java f885a6b822d8e20ccf894d535dada35390e126f7
> webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855eb884289ad2dacd05ab8864447ee9b365
> webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java 70b24820559cfc13013563f20b314b364dd71f5b
> webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java a14f939274f42dab47e03a2db55fb9e0f67f2dd5
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff800036bc9bd4b5d19ef449ce940eeca3aa475
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 30200b5535b04c4025ddc7594a90057c6ddb0149
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd730a256f53a7e9d29421010f029b3bcc51
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c578067b3a9f62704c45971054f14866956
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 4b45927fb10e9774e6cdd109bec8dae18362e7b5
> webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578d224de982460565d3dede4135513ae1f
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java 595387aec48bbcd369c4610a630956974ee16820
> webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de84420a321324ed29f15159049775d2e1558
> webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c968d6bdda0a6eed341873856ebf8d046
> webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0f867a00b22925c360bf842402111728d
> webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd25bf7eb9836ba77fb7a2cfc45e08ab75f
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b81175ada20501659c5bf74a9b84057089
> webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de471715554d3fe7dd45e56d517a657b1fa
> webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java f85892acb133af167d83e39024fd8e2d306c2cf3
> webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9baa67abafd36bd3f66e27bfae29f9f53
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc6386fe4fc1b9e7ad5ab8d12828c09579f05
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java ea86cc689cf6a2950116f64188263ff7515721a3
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f2d2844a39b10ac5a31d883e671907d64
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc392c2567ffdc133643839c6604d04ef086
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java f96fa752f7336669d08c8498e420d3627800c9e9
> webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf108be564e2c496b17ef69b6fc3c35277
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121fd556d9ad7a424bcf2fb4419af1f50f34
>
> Diff: https://reviews.apache.org/r/53789/diff/
>
>
> Testing
> -------
>
> Unit Tests passing.
>
>
> Thanks,
>
> Apoorv Naik
>
>