You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/21 01:08:00 UTC
[jira] [Work logged] (AVRO-3540) .NET/C# Allow Reflect reader/writer to support Dictionaries keyed by something other than string
[ https://issues.apache.org/jira/browse/AVRO-3540?focusedWorklogId=783177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783177 ]
ASF GitHub Bot logged work on AVRO-3540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/22 01:07
Start Date: 21/Jun/22 01:07
Worklog Time Spent: 10m
Work Description: czf opened a new pull request, #1727:
URL: https://github.com/apache/avro/pull/1727
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3540
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
- [ ] TestMapWithConverterSucceeds - tests new functionality
- [ ] TestMapWithoutConverterFails - covers maintain existing behavior as this is opt-in
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
Issue Time Tracking
-------------------
Worklog Id: (was: 783177)
Remaining Estimate: 0h
Time Spent: 10m
> .NET/C# Allow Reflect reader/writer to support Dictionaries keyed by something other than string
> ------------------------------------------------------------------------------------------------
>
> Key: AVRO-3540
> URL: https://issues.apache.org/jira/browse/AVRO-3540
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Christopher Fingar
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the existing reflect code does not support converting other key types to string.
> My change provides an opt-in functionality using the default converters.
> This allows users to keep there existing code instead of converting types to use string keys.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)