You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/30 01:52:26 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #16248: [fix] [transaction] Cmd-Subscribe and Cmd-Producer will not succeed even after 100 retries

congbobo184 commented on code in PR #16248:
URL: https://github.com/apache/pulsar/pull/16248#discussion_r909138090


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java:
##########
@@ -795,7 +795,7 @@ public void testChangeSubscriptionType() throws Exception {
     public void testAddRemoveConsumer() throws Exception {
         PersistentTopic topic = new PersistentTopic(successTopicName, ledgerMock, brokerService);
         PersistentSubscription sub = new PersistentSubscription(topic, "sub-1", cursorMock, false);
-
+        topic.getSubscriptions().put("sub-1", sub);

Review Comment:
   why add this line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org