You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/10/03 19:30:50 UTC
Review Request: SQOOP-619: Display user persistent id of newly created
connection and job objects
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7410/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've improved VerificationBean to also transfer ID if it's present and fixed user code to display it.
This addresses bug SQOOP-619.
https://issues.apache.org/jira/browse/SQOOP-619
Diffs
-----
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 904624c
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 1a8b901
common/src/main/java/org/apache/sqoop/json/ValidationBean.java b56f6ed
Diff: https://reviews.apache.org/r/7410/diff/
Testing
-------
I've performed just manual testing.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-619: Display user persistent id of newly created
connection and job objects
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7410/#review12197
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Oct. 4, 2012, 1:01 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7410/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 1:01 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've improved VerificationBean to also transfer ID if it's present and fixed user code to display it.
>
>
> This addresses bug SQOOP-619.
> https://issues.apache.org/jira/browse/SQOOP-619
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 9716de6
> client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 6c579d0
> client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 904624c
> client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 1a8b901
> common/src/main/java/org/apache/sqoop/json/ValidationBean.java b56f6ed
>
> Diff: https://reviews.apache.org/r/7410/diff/
>
>
> Testing
> -------
>
> I've performed just manual testing.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-619: Display user persistent id of newly created
connection and job objects
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7410/
-----------------------------------------------------------
(Updated Oct. 4, 2012, 1:01 a.m.)
Review request for Sqoop.
Changes
-------
I've added same functionality to clone command that was recently added.
Description
-------
I've improved VerificationBean to also transfer ID if it's present and fixed user code to display it.
This addresses bug SQOOP-619.
https://issues.apache.org/jira/browse/SQOOP-619
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 9716de6
client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 6c579d0
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 904624c
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 1a8b901
common/src/main/java/org/apache/sqoop/json/ValidationBean.java b56f6ed
Diff: https://reviews.apache.org/r/7410/diff/
Testing
-------
I've performed just manual testing.
Thanks,
Jarek Cecho