You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/17 06:25:20 UTC
[GitHub] [doris] yixiutt opened a new pull request, #13409: [improvement](compaction) delete num based compaction policy
yixiutt opened a new pull request, #13409:
URL: https://github.com/apache/doris/pull/13409
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13409: [improvement](compaction) delete num based compaction policy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13409:
URL: https://github.com/apache/doris/pull/13409#issuecomment-1281945951
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #13409: [improvement](compaction) delete num based compaction policy
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #13409:
URL: https://github.com/apache/doris/pull/13409#discussion_r997779090
##########
be/src/olap/cumulative_compaction_policy.h:
##########
@@ -248,13 +193,7 @@ class CumulativeCompactionPolicyFactory {
public:
/// Static factory function. It can product different policy according to the `policy` parameter and use tablet ptr
/// to construct the policy. Now it can product size based and num based policies.
- static std::shared_ptr<CumulativeCompactionPolicy> create_cumulative_compaction_policy(
- std::string policy);
-
-private:
- /// It is a static function to help to check the policy config and convert to CompactionPolicy enum variable
- static void _parse_cumulative_compaction_policy(std::string policy,
- CompactionPolicy* policy_type);
+ static std::shared_ptr<CumulativeCompactionPolicy> create_cumulative_compaction_policy();
Review Comment:
The comment of this method should also be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #13409: [improvement](compaction) delete num based compaction policy
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #13409:
URL: https://github.com/apache/doris/pull/13409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org