You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/10 19:18:43 UTC
[GitHub] [druid] mcbrewster opened a new pull request #9500: Update
druid-query-toolkit to version 4.0
mcbrewster opened a new pull request #9500: Update druid-query-toolkit to version 4.0
URL: https://github.com/apache/druid/pull/9500
<img width="937" alt="Screen Shot 2020-03-10 at 12 18 22 PM" src="https://user-images.githubusercontent.com/37322608/76350585-42fc4900-62c9-11ea-89ce-7af41478c8f6.png">
Updates the druid query toolkit to the latest version. The latest version is more throughly tested and can parse a wider range of queries including those with comments. Minor adjustments have been made to the api.
Additionally the class to denote the direction of a query was not applying the correct class to all ordered columns, this is fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on issue #9500: Web console: update
druid-query-toolkit to version 0.4.x
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on issue #9500: Web console: update druid-query-toolkit to version 0.4.x
URL: https://github.com/apache/druid/pull/9500#issuecomment-598990632
This is great, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on issue #9500: Update
druid-query-toolkit to version 4.0
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #9500: Update druid-query-toolkit to version 4.0
URL: https://github.com/apache/druid/pull/9500#issuecomment-597826675
This pull request **introduces 1 alert** when merging 52bdcc15a1dac283897aaf8f23c55c3fd64715b8 into 2ef5c17441a450171523653787743db76a3e3bdb - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-b2a7d891857e6c60bbd7aa46cb214362a23b1609)
**new alerts:**
* 1 for Useless conditional
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on issue #9500: Web console: update
druid-query-toolkit to version 0.4.x
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on issue #9500: Web console: update druid-query-toolkit to version 0.4.x
URL: https://github.com/apache/druid/pull/9500#issuecomment-598990654
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #9500: Web console: update
druid-query-toolkit to version 0.4.x
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #9500: Web console: update druid-query-toolkit to version 0.4.x
URL: https://github.com/apache/druid/pull/9500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #9500:
Update druid-query-toolkit to version 4.0
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #9500: Update druid-query-toolkit to version 4.0
URL: https://github.com/apache/druid/pull/9500#discussion_r390620414
##########
File path: web-console/src/views/query-view/query-output/query-output.tsx
##########
@@ -239,12 +239,14 @@ export const QueryOutput = React.memo(function QueryOutput(props: QueryOutputPro
const sorted = parsedQuery.getSorted();
if (sorted) {
className.push(
- sorted.map(sorted => {
- if (sorted.id === header) {
- return sorted.desc ? '-sort-desc' : '-sort-asc';
- }
- return '';
- })[0],
+ sorted
+ .map(sorted => {
+ if (sorted.id === header) {
+ return sorted.desc ? '-sort-desc' : '-sort-asc';
+ }
+ return '';
+ })
+ .join(''),
Review comment:
This definitely does not make sense this could create classes like `-sort-desc-sort-asc`
The existing code probably does not make sense either as it will add the `undefined` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org