You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/01 16:02:30 UTC
[GitHub] srkukarni commented on a change in pull request #2502: Fix Handling
of user defined nar sources/sinks
srkukarni commented on a change in pull request #2502: Fix Handling of user defined nar sources/sinks
URL: https://github.com/apache/incubator-pulsar/pull/2502#discussion_r214517272
##########
File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -246,12 +246,12 @@ public void run() {
private void loadJars() throws Exception {
- if (jarFile.endsWith(".nar")) {
- // The functions code is contained in a NAR archive
+ try {
+ // Let's first try to treat it as a nar archive
fnCache.registerFunctionInstanceWithArchive(instanceConfig.getFunctionId(), instanceConfig.getInstanceId(),
jarFile);
- } else {
- log.info("Loading JAR files for function {} from archive {}", instanceConfig, jarFile);
+ } catch (Exception e) {
Review comment:
Changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services