You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@yunikorn.apache.org by "Manikandan R (Jira)" <ji...@apache.org> on 2023/11/07 05:08:00 UTC

[jira] [Commented] (YUNIKORN-2125) Remove literals from handlers_test.go

    [ https://issues.apache.org/jira/browse/YUNIKORN-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783477#comment-17783477 ] 

Manikandan R commented on YUNIKORN-2125:
----------------------------------------

Thank you [~makinyemi] for your contributions

> Remove literals from handlers_test.go  
> ---------------------------------------
>
>                 Key: YUNIKORN-2125
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2125
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - common
>            Reporter: Michael Akinyemi
>            Assignee: Michael Akinyemi
>            Priority: Minor
>              Labels: newbie, pull-request-available
>
> [https://github.com/apache/yunikorn-core/blob/master/pkg/webservice/handlers_test.go]
> While going through the handler_test i noticed some of the functions use constant variables for the returned error messages (which exist within the webservice package), while others use literal strings. We should replace the literals that have constant values. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org