You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/02/01 17:02:05 UTC
[GitHub] [fineract] percyashu opened a new pull request #707: FINERACT-775
Clean up Util
percyashu opened a new pull request #707: FINERACT-775 Clean up Util
URL: https://github.com/apache/fineract/pull/707
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket: https://issues.apache.org/jira/browse/FINERACT-775
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on a change in pull request #707:
FINERACT-775 Clean up Util
Posted by GitBox <gi...@apache.org>.
percyashu commented on a change in pull request #707: FINERACT-775 Clean up Util
URL: https://github.com/apache/fineract/pull/707#discussion_r373870297
##########
File path: fineract-provider/src/test/java/org/apache/fineract/common/Utils.java
##########
@@ -28,13 +28,11 @@
import com.jayway.restassured.path.json.JsonPath;
import com.jayway.restassured.specification.RequestSpecification;
import com.jayway.restassured.specification.ResponseSpecification;
-import java.text.ParseException;
-import java.text.SimpleDateFormat;
-import java.util.Locale;
-import java.util.Random;
import org.apache.commons.lang.StringUtils;
import org.apache.http.conn.HttpHostConnectException;
+
+
/**
* Util for RestAssured tests. This class here in src/test is copy/pasted :(
* from and identical to the one in src/integrationTest; please keep it in sync.
Review comment:
@vorburger src/integrationTest seems to be already clean since all methods are used in integration unlike those copied into src/test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #707:
FINERACT-775 Clean up Util
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #707: FINERACT-775 Clean up Util
URL: https://github.com/apache/fineract/pull/707#discussion_r373835403
##########
File path: fineract-provider/src/test/java/org/apache/fineract/common/Utils.java
##########
@@ -28,13 +28,11 @@
import com.jayway.restassured.path.json.JsonPath;
import com.jayway.restassured.specification.RequestSpecification;
import com.jayway.restassured.specification.ResponseSpecification;
-import java.text.ParseException;
-import java.text.SimpleDateFormat;
-import java.util.Locale;
-import java.util.Random;
import org.apache.commons.lang.StringUtils;
import org.apache.http.conn.HttpHostConnectException;
+
+
/**
* Util for RestAssured tests. This class here in src/test is copy/pasted :(
* from and identical to the one in src/integrationTest; please keep it in sync.
Review comment:
@percyashu do you want to do the same clean up in the same class in src/integrationTest as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #707: FINERACT-775 Clean
up Util
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #707: FINERACT-775 Clean up Util
URL: https://github.com/apache/fineract/pull/707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on issue #707: FINERACT-775 Clean up
Util
Posted by GitBox <gi...@apache.org>.
percyashu commented on issue #707: FINERACT-775 Clean up Util
URL: https://github.com/apache/fineract/pull/707#issuecomment-581051448
@vorburger could you review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services