You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/15 07:43:28 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35509: [SPARK-38201][K8S] Fix `KubernetesUtils#uploadFileToHadoopCompatibleFS` use passed in `delSrc` and `overwrite`

dongjoon-hyun commented on a change in pull request #35509:
URL: https://github.com/apache/spark/pull/35509#discussion_r806535077



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesUtilsSuite.scala
##########
@@ -17,13 +17,21 @@
 
 package org.apache.spark.deploy.k8s
 
+import java.io.File
+import java.nio.charset.Charset
+import java.util.concurrent.TimeUnit
+
 import scala.collection.JavaConverters._
 
 import io.fabric8.kubernetes.api.model.{ContainerBuilder, PodBuilder}
+import org.apache.commons.io.FileUtils
+import org.apache.hadoop.conf.Configuration
+import org.apache.hadoop.fs.Path
+import org.scalatest.PrivateMethodTester
 
 import org.apache.spark.SparkFunSuite

Review comment:
       ```scala
   -import org.apache.spark.SparkFunSuite
   +import org.apache.spark.{SparkException, SparkFunSuite}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org