You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2019/03/21 11:00:41 UTC

[GitHub] [incubator-weex] NickeyLin commented on a change in pull request #2215: [iOS] Fix the border of view hasn't gone after changing border width to 0 dynamically; (#2153)

NickeyLin commented on a change in pull request #2215: [iOS] Fix the border of view hasn't gone after changing border width to 0 dynamically; (#2153)
URL: https://github.com/apache/incubator-weex/pull/2215#discussion_r267706496
 
 

 ##########
 File path: ios/sdk/WeexSDK/Sources/Display/WXComponent+Display.m
 ##########
 @@ -61,7 +70,7 @@ - (BOOL)needsDrawRect
         return YES;
     }
     
-    if (![self _needsDrawBorder]) {
+    if (![self _needsDrawBorder] && _lastBorderRecords == WXComponentBorderRecordNone) {
 
 Review comment:
   Return NO only if there is no border for the last time and this time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services