You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/09/17 21:01:28 UTC

[PR] Add mdep pattern and deduplicate fallback warnings in TestSuiteOrdering [maven]

gnodet opened a new pull request, #13171:
URL: https://github.com/apache/maven/pull/13171

   Fixes two issues with the dynamic `TestSuiteOrdering` introduced in #11251:
   
   ## Problems
   
   1. **`MavenITmdep<N>Test` classes not matched** — `MavenITmdep0590ClassifiedPomArtifactFromReactorTest` falls through all patterns because the `IT_PATTERN` requires digits immediately after `MavenIT`, but `mdep` sits between them. These tests still ran (via fallback), but weren't ordered numerically.
   
   2. **Fallback warning spammed** — `getOrderKey()` is called once per surefire thread per test class, so a single unrecognized class (e.g. `MavenITConsumerPomBomFromSettingsRepoTest`) generated 20+ identical log lines in a parallel run.
   
   ## Fix
   
   - Add `MDEP_PATTERN` (`.*MavenITmdep(\d+).*`) to handle `mdep`-prefixed classes in the same ordering bucket as `it`-prefixed tests
   - Deduplicate the fallback warning with a `ConcurrentHashMap`-backed `Set` — each class is logged at most once per JVM run
   - Explicit `MavenITBootstrapTest` handling (highest key) to guarantee it always runs first regardless of future renames
   - Updated Javadoc
   
   Related: the same fix is applied to `maven-4.0.x` in #13169.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add mdep pattern and deduplicate fallback warnings in TestSuiteOrdering [maven]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #13171:
URL: https://github.com/apache/maven/pull/13171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org