You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/03/13 21:07:44 UTC
Review Request 32056: Performance: ActionScheduler loads too many
objects per Stage iteration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32056/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-10065
https://issues.apache.org/jira/browse/AMBARI-10065
Repository: ambari
Description
-------
During analysis of a 400 node cluster, the ActionScheduler is loading too many stages, when it already has a handle to the correct stage. The entire Request is not needed, when the code only checks the exclusive flag.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java b7bfef9
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8d85d19
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java df75c0c
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java ca169b8
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java ce6a0b8
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 890ad80
Diff: https://reviews.apache.org/r/32056/diff/
Testing
-------
Manual testing + perf testing
Automated pending
Thanks,
Nate Cole
Re: Review Request 32056: Performance: ActionScheduler loads too many
objects per Stage iteration
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32056/#review76417
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 13, 2015, 8:07 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32056/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 8:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10065
> https://issues.apache.org/jira/browse/AMBARI-10065
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During analysis of a 400 node cluster, the ActionScheduler is loading too many stages, when it already has a handle to the correct stage. The entire Request is not needed, when the code only checks the exclusive flag.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java b7bfef9
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8d85d19
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java df75c0c
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java ca169b8
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java ce6a0b8
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 890ad80
>
> Diff: https://reviews.apache.org/r/32056/diff/
>
>
> Testing
> -------
>
> Manual testing + perf testing
>
> Automated pending
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 32056: Performance: ActionScheduler loads too many
objects per Stage iteration
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32056/#review76418
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On March 13, 2015, 4:07 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32056/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 4:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10065
> https://issues.apache.org/jira/browse/AMBARI-10065
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During analysis of a 400 node cluster, the ActionScheduler is loading too many stages, when it already has a handle to the correct stage. The entire Request is not needed, when the code only checks the exclusive flag.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java b7bfef9
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java 8d85d19
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java df75c0c
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java ca169b8
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java ce6a0b8
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 890ad80
>
> Diff: https://reviews.apache.org/r/32056/diff/
>
>
> Testing
> -------
>
> Manual testing + perf testing
>
> Automated pending
>
>
> Thanks,
>
> Nate Cole
>
>