You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Pearl1594 (via GitHub)" <gi...@apache.org> on 2025/02/28 17:14:48 UTC
[PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Pearl1594 opened a new pull request, #10484:
URL: https://github.com/apache/cloudstack/pull/10484
### Description
This PR shows host oobm parameter if is is configured:
Post request sent:
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2696966414
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on code in PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#discussion_r1976471725
##########
ui/public/locales/en.json:
##########
@@ -3066,6 +3066,7 @@
"message.no.description": "No description entered.",
"message.offering.internet.protocol.warning": "WARNING: IPv6 supported Networks use static routing and will require upstream routes to be configured manually.",
"message.offering.ipv6.warning": "Please refer documentation for creating IPv6 enabled Network/VPC offering <a href='http://docs.cloudstack.apache.org/en/latest/plugins/ipv6.html#isolated-network-and-vpc-tier'>IPv6 support in CloudStack - Isolated Networks and VPC Network Tiers</a>",
+"message.oobm.configured": "Successfully configured Out of Band Management for host",
Review Comment:
```suggestion
"message.oobm.configured": "Successfully configured out-of-band management for host",
```
##########
ui/src/views/infra/ConfigureHostOOBM.vue:
##########
@@ -0,0 +1,172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-form
+ :ref="formRef"
+ :model="form"
+ :rules="rules"
+ @finish="handleSubmit"
+ v-ctrl-enter="handleSubmit"
+ class="form"
+ layout="vertical"
+ >
+ <a-alert type="warning">
+ <template #message>
+ <span v-html="$t('label.outofbandmanagement.configure')" />
+ </template>
+ </a-alert>
+ <div style="margin-top: 10px;">
+ <a-form-item name="address" ref="address">
+ <template #label>
+ <tooltip-label :title="$t('label.address')" :tooltip="apiParams.address.description"/>
+ </template>
+ <a-input
+ v-model:value="form.address"
+ v-focus="true" />
+ </a-form-item>
+ <a-form-item name="port" ref="port">
+ <template #label>
+ <tooltip-label :title="$t('label.port')" :tooltip="apiParams.port.description"/>
+ </template>
+ <a-input
+ v-model:value="form.port" />
+ </a-form-item>
+ <a-form-item name="username" ref="username">
+ <template #label>
+ <tooltip-label :title="$t('label.username')" :tooltip="apiParams.username.description"/>
+ </template>
+ <a-input
+ v-model:value="form.username" />
+ </a-form-item>
+ <a-form-item name="password" ref="password">
+ <template #label>
+ <tooltip-label :title="$t('label.password')" :tooltip="apiParams.password.description"/>
+ </template>
+ <a-input-password
+ v-model:value="form.password"
+ :placeholder="apiParams.password.description"/>
+ </a-form-item>
+ <a-form-item name="driver" ref="driver">
+ <template #label>
+ <tooltip-label :title="$t('label.driver')" :tooltip="apiParams.driver.description"/>
+ </template>
+ <a-select
+ v-model:value="form.driver"
+ style="width: 100%;"
+ optionFilterProp="value"
+ :filterOption="(input, option) => {
+ return option.value.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }" >
+ <a-select-option key="" label="">{{ }}</a-select-option>
+ <a-select-option value="ipmitool">ipmitool</a-select-option>
+ <a-select-option value="nestedcloudstack">nestedcloudstack</a-select-option>
+ <a-select-option value="redfish">redfish</a-select-option>
+ </a-select>
+ </a-form-item>
+ </div>
+ <div :span="24" class="action-button">
+ <a-button @click="$emit('close-action')">{{ $t('label.cancel') }}</a-button>
+ <a-button type="primary" @click="handleSubmit" ref="submit">{{ $t('label.ok') }}</a-button>
+ </div>
+ </a-form>
+ </div>
+</template>
+
+<script>
+import TooltipLabel from '@/components/widgets/TooltipLabel'
+import { ref, reactive, toRaw } from 'vue'
+import { api } from '@/api'
+
+export default {
+ name: 'ConfigureHostOOBM',
+ components: {
+ TooltipLabel
+ },
+ props: {
+ resource: {
+ type: Object,
+ required: true
+ }
+ },
+ data () {
+ return {
+ }
+ },
+ beforeCreate () {
+ this.apiParams = this.$getApiParams('configureOutOfBandManagement')
+ },
+ created () {
+ this.initForm()
+ },
+ methods: {
+ initForm () {
+ this.formRef = ref()
+ this.form = reactive({
+ address: this.resource.outofbandmanagement.address || '',
+ port: this.resource.outofbandmanagement.port || '',
+ username: this.resource.outofbandmanagement.username || '',
+ password: '',
+ driver: this.resource.outofbandmanagement.driver || ''
+ })
+ this.rules = reactive({
+ address: [{ required: true, message: this.$t('message.error.required.input') }],
+ port: [{ required: true, message: this.$t('message.error.required.input') }],
+ username: [{ required: true, message: this.$t('message.error.required.input') }],
+ password: [{ required: true, message: this.$t('message.error.required.input') }],
+ driver: [{ required: true, message: this.$t('message.error.required.input') }]
+ })
+ },
+ handleSubmit (e) {
+ e.preventDefault()
+ this.formRef.value.validate().then(() => {
+ const values = toRaw(this.form)
+ var params = {
Review Comment:
```suggestion
const params = {
```
##########
ui/src/views/infra/ConfigureHostOOBM.vue:
##########
@@ -0,0 +1,172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-form
+ :ref="formRef"
+ :model="form"
+ :rules="rules"
+ @finish="handleSubmit"
+ v-ctrl-enter="handleSubmit"
+ class="form"
+ layout="vertical"
+ >
+ <a-alert type="warning">
+ <template #message>
+ <span v-html="$t('label.outofbandmanagement.configure')" />
+ </template>
+ </a-alert>
+ <div style="margin-top: 10px;">
+ <a-form-item name="address" ref="address">
+ <template #label>
+ <tooltip-label :title="$t('label.address')" :tooltip="apiParams.address.description"/>
+ </template>
+ <a-input
+ v-model:value="form.address"
+ v-focus="true" />
+ </a-form-item>
+ <a-form-item name="port" ref="port">
+ <template #label>
+ <tooltip-label :title="$t('label.port')" :tooltip="apiParams.port.description"/>
+ </template>
+ <a-input
+ v-model:value="form.port" />
+ </a-form-item>
+ <a-form-item name="username" ref="username">
+ <template #label>
+ <tooltip-label :title="$t('label.username')" :tooltip="apiParams.username.description"/>
+ </template>
+ <a-input
+ v-model:value="form.username" />
+ </a-form-item>
+ <a-form-item name="password" ref="password">
+ <template #label>
+ <tooltip-label :title="$t('label.password')" :tooltip="apiParams.password.description"/>
+ </template>
+ <a-input-password
+ v-model:value="form.password"
+ :placeholder="apiParams.password.description"/>
+ </a-form-item>
+ <a-form-item name="driver" ref="driver">
+ <template #label>
+ <tooltip-label :title="$t('label.driver')" :tooltip="apiParams.driver.description"/>
+ </template>
+ <a-select
+ v-model:value="form.driver"
+ style="width: 100%;"
+ optionFilterProp="value"
+ :filterOption="(input, option) => {
+ return option.value.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }" >
+ <a-select-option key="" label="">{{ }}</a-select-option>
+ <a-select-option value="ipmitool">ipmitool</a-select-option>
+ <a-select-option value="nestedcloudstack">nestedcloudstack</a-select-option>
+ <a-select-option value="redfish">redfish</a-select-option>
+ </a-select>
+ </a-form-item>
+ </div>
+ <div :span="24" class="action-button">
+ <a-button @click="$emit('close-action')">{{ $t('label.cancel') }}</a-button>
+ <a-button type="primary" @click="handleSubmit" ref="submit">{{ $t('label.ok') }}</a-button>
+ </div>
+ </a-form>
+ </div>
+</template>
+
+<script>
+import TooltipLabel from '@/components/widgets/TooltipLabel'
+import { ref, reactive, toRaw } from 'vue'
+import { api } from '@/api'
+
+export default {
+ name: 'ConfigureHostOOBM',
+ components: {
+ TooltipLabel
+ },
+ props: {
+ resource: {
+ type: Object,
+ required: true
+ }
+ },
+ data () {
+ return {
+ }
+ },
+ beforeCreate () {
+ this.apiParams = this.$getApiParams('configureOutOfBandManagement')
+ },
+ created () {
+ this.initForm()
+ },
+ methods: {
+ initForm () {
+ this.formRef = ref()
+ this.form = reactive({
+ address: this.resource.outofbandmanagement.address || '',
+ port: this.resource.outofbandmanagement.port || '',
+ username: this.resource.outofbandmanagement.username || '',
+ password: '',
+ driver: this.resource.outofbandmanagement.driver || ''
+ })
+ this.rules = reactive({
+ address: [{ required: true, message: this.$t('message.error.required.input') }],
+ port: [{ required: true, message: this.$t('message.error.required.input') }],
+ username: [{ required: true, message: this.$t('message.error.required.input') }],
+ password: [{ required: true, message: this.$t('message.error.required.input') }],
+ driver: [{ required: true, message: this.$t('message.error.required.input') }]
+ })
+ },
+ handleSubmit (e) {
+ e.preventDefault()
+ this.formRef.value.validate().then(() => {
+ const values = toRaw(this.form)
+ var params = {
+ hostid: this.resource.id,
+ address: values.address,
+ port: values.port,
+ username: values.username,
+ password: values.password,
+ driver: values.driver
+ }
+
+ api('configureOutOfBandManagement', {}, 'POST', params).then(_ => {
+ this.$message.success(`${this.$t('message.oobm.configured')}`)
Review Comment:
```suggestion
this.$message.success(this.$t('message.oobm.configured'))
```
##########
ui/src/views/infra/ConfigureHostOOBM.vue:
##########
@@ -0,0 +1,172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div class="form-layout">
+ <a-form
+ :ref="formRef"
+ :model="form"
+ :rules="rules"
+ @finish="handleSubmit"
+ v-ctrl-enter="handleSubmit"
+ class="form"
+ layout="vertical"
+ >
+ <a-alert type="warning">
+ <template #message>
+ <span v-html="$t('label.outofbandmanagement.configure')" />
+ </template>
+ </a-alert>
+ <div style="margin-top: 10px;">
+ <a-form-item name="address" ref="address">
+ <template #label>
+ <tooltip-label :title="$t('label.address')" :tooltip="apiParams.address.description"/>
+ </template>
+ <a-input
+ v-model:value="form.address"
+ v-focus="true" />
+ </a-form-item>
+ <a-form-item name="port" ref="port">
+ <template #label>
+ <tooltip-label :title="$t('label.port')" :tooltip="apiParams.port.description"/>
+ </template>
+ <a-input
+ v-model:value="form.port" />
+ </a-form-item>
+ <a-form-item name="username" ref="username">
+ <template #label>
+ <tooltip-label :title="$t('label.username')" :tooltip="apiParams.username.description"/>
+ </template>
+ <a-input
+ v-model:value="form.username" />
+ </a-form-item>
+ <a-form-item name="password" ref="password">
+ <template #label>
+ <tooltip-label :title="$t('label.password')" :tooltip="apiParams.password.description"/>
+ </template>
+ <a-input-password
+ v-model:value="form.password"
+ :placeholder="apiParams.password.description"/>
+ </a-form-item>
+ <a-form-item name="driver" ref="driver">
+ <template #label>
+ <tooltip-label :title="$t('label.driver')" :tooltip="apiParams.driver.description"/>
+ </template>
+ <a-select
+ v-model:value="form.driver"
+ style="width: 100%;"
+ optionFilterProp="value"
+ :filterOption="(input, option) => {
+ return option.value.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }" >
+ <a-select-option key="" label="">{{ }}</a-select-option>
+ <a-select-option value="ipmitool">ipmitool</a-select-option>
+ <a-select-option value="nestedcloudstack">nestedcloudstack</a-select-option>
+ <a-select-option value="redfish">redfish</a-select-option>
+ </a-select>
+ </a-form-item>
+ </div>
+ <div :span="24" class="action-button">
+ <a-button @click="$emit('close-action')">{{ $t('label.cancel') }}</a-button>
+ <a-button type="primary" @click="handleSubmit" ref="submit">{{ $t('label.ok') }}</a-button>
+ </div>
+ </a-form>
+ </div>
+</template>
+
+<script>
+import TooltipLabel from '@/components/widgets/TooltipLabel'
+import { ref, reactive, toRaw } from 'vue'
+import { api } from '@/api'
+
+export default {
+ name: 'ConfigureHostOOBM',
+ components: {
+ TooltipLabel
+ },
+ props: {
+ resource: {
+ type: Object,
+ required: true
+ }
+ },
+ data () {
+ return {
+ }
+ },
+ beforeCreate () {
+ this.apiParams = this.$getApiParams('configureOutOfBandManagement')
+ },
+ created () {
+ this.initForm()
+ },
+ methods: {
+ initForm () {
+ this.formRef = ref()
+ this.form = reactive({
+ address: this.resource.outofbandmanagement.address || '',
+ port: this.resource.outofbandmanagement.port || '',
+ username: this.resource.outofbandmanagement.username || '',
+ password: '',
+ driver: this.resource.outofbandmanagement.driver || ''
+ })
+ this.rules = reactive({
+ address: [{ required: true, message: this.$t('message.error.required.input') }],
+ port: [{ required: true, message: this.$t('message.error.required.input') }],
+ username: [{ required: true, message: this.$t('message.error.required.input') }],
+ password: [{ required: true, message: this.$t('message.error.required.input') }],
+ driver: [{ required: true, message: this.$t('message.error.required.input') }]
+ })
+ },
+ handleSubmit (e) {
+ e.preventDefault()
+ this.formRef.value.validate().then(() => {
+ const values = toRaw(this.form)
+ var params = {
+ hostid: this.resource.id,
+ address: values.address,
+ port: values.port,
+ username: values.username,
+ password: values.password,
+ driver: values.driver
+ }
+
+ api('configureOutOfBandManagement', {}, 'POST', params).then(_ => {
+ this.$message.success(`${this.$t('message.oobm.configured')}`)
+ this.$emit('close-action')
+ }).catch(error => {
+ this.$notifyError(error)
+ })
+ })
+ }
+ }
+}
+</script>
+
+<style scoped>
+.reason {
+ padding-top: 20px
+}
Review Comment:
```suggestion
```
Apparently, this CSS class is not being used in the component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2692359114
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2692359410
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2695033103
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10484) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10484&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10484&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10484&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10484&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10484&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10484)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2691265987
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10484) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10484&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10484&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10484&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10484&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10484&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10484)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2691164810
Comment: https://github.com/apache/cloudstack/pull/10472#pullrequestreview-2648340789 has been address in the this PR @DaanHoogland @kiranchavala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2692365345
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10484 (QA-JID-564)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2697029339
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10484 (QA-JID-568)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2696965172
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 merged PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Show Host OOBM parameter in form if configured [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10484:
URL: https://github.com/apache/cloudstack/pull/10484#issuecomment-2691177561
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10484?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.28%. Comparing base [(`f50de89`)](https://app.codecov.io/gh/apache/cloudstack/commit/f50de8981afd157ceb8f9b1bfa2248c5d1c339d1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d730c42`)](https://app.codecov.io/gh/apache/cloudstack/commit/d730c42d9f8c236da38a91b10de6bf58ce1edfbc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (f50de89) and HEAD (d730c42). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (f50de89) | HEAD (d730c42) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #10484 +/- ##
=============================================
- Coverage 15.16% 4.28% -10.88%
=============================================
Files 5413 368 -5045
Lines 474782 29658 -445124
Branches 57903 5205 -52698
=============================================
- Hits 72010 1272 -70738
+ Misses 394722 28241 -366481
+ Partials 8050 145 -7905
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10484/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10484/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10484/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10484?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org