You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 21:31:56 UTC
[GitHub] [incubator-superset] riahk opened a new pull request #11005: feat: saved query list view + sort/filters
riahk opened a new pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005
### SUMMARY
- [x] Convert Saved Queries list to React CRUD page `SavedQueryList` with `ListView`
- [ ] Make list sortable
- [ ] Make list filterable by database, schema
- [ ] Make list searchable by query name
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1265" alt="Screen Shot 2020-09-22 at 2 31 06 PM" src="https://user-images.githubusercontent.com/8216382/93939818-4644a880-fce0-11ea-9e9f-5b78e84e8fca.png">
### TEST PLAN
- [ ] Add unit tests to `SavedQueryList_spec`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3a08fd04f3f9ebaaa48fa554028c26062de42f02?el=desc) will **increase** coverage by `4.06%`.
> The diff coverage is `85.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
+ Coverage 61.70% 65.76% +4.06%
==========================================
Files 816 816
Lines 38586 38634 +48
Branches 3650 3655 +5
==========================================
+ Hits 23808 25407 +1599
+ Misses 14598 13125 -1473
+ Partials 180 102 -78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `57.16% <7.89%> (?)` | |
| #javascript | `62.25% <85.10%> (+0.06%)` | :arrow_up: |
| #python | `60.96% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `87.03% <85.10%> (-12.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.29% <0.00%> (-0.67%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.67% <0.00%> (-0.59%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [3a08fd0...80e36ac](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e337355162f3f5716f1cad79a6b51a1359fecac8?el=desc) will **decrease** coverage by `4.33%`.
> The diff coverage is `85.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 66.05% 61.72% -4.34%
==========================================
Files 816 816
Lines 38589 38631 +42
Branches 3650 3655 +5
==========================================
- Hits 25491 23846 -1645
- Misses 12996 14605 +1609
- Partials 102 180 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.25% <85.10%> (+0.06%)` | :arrow_up: |
| #python | `61.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `87.03% <85.10%> (-12.97%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [169 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [e337355...a1e7c24](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#discussion_r494513003
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -17,28 +17,283 @@
* under the License.
*/
-import React from 'react';
+import { t, styled } from '@superset-ui/core';
+import React, { useMemo } from 'react';
+import {
+ createFetchRelated,
+ createFetchDistinct,
+ createErrorHandler,
+} from 'src/views/CRUD/utils';
+import { Popover } from 'src/common/components';
import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { useListViewResource } from 'src/views/CRUD/hooks';
import SubMenu, { SubMenuProps } from 'src/components/Menu/SubMenu';
+import ListView, { Filters } from 'src/components/ListView';
+import TooltipWrapper from 'src/components/TooltipWrapper';
+import Icon from 'src/components/Icon';
import { commonMenuData } from 'src/views/CRUD/data/common';
+const PAGE_SIZE = 25;
+
interface SavedQueryListProps {
addDangerToast: (msg: string) => void;
addSuccessToast: (msg: string) => void;
}
+type SavedQueryObject = {};
+
+const StyledTableLabel = styled.div`
+ .count {
+ margin-left: 5px;
+ color: ${({ theme }) => theme.colors.primary.base};
+ text-decoration: underline;
+ cursor: pointer;
+ }
+`;
+
+const StyledPopoverItem = styled.div`
+ color: ${({ theme }) => theme.colors.grayscale.dark2};
+`;
+
function SavedQueryList({
addDangerToast,
addSuccessToast,
}: SavedQueryListProps) {
+ const {
+ state: { loading, resourceCount: queryCount, resourceCollection: queries },
+ hasPerm,
+ fetchData,
+ // refreshData, //TODO: add back later when editing?
+ } = useListViewResource<SavedQueryObject>(
+ 'saved_query',
+ t('saved_queries'),
+ addDangerToast,
+ );
+
+ const canCreate = hasPerm('can_add');
+ const canEdit = hasPerm('can_edit');
+ const canDelete = hasPerm('can_delete');
+
const menuData: SubMenuProps = {
activeChild: 'Saved Queries',
...commonMenuData,
};
+ const initialSort = [{ id: 'label', desc: true }];
+ const columns = useMemo(
+ () => [
+ {
+ accessor: 'label',
+ Header: t('Name'),
+ },
+ {
+ accessor: 'database.database_name',
+ Header: t('Database'),
+ },
+ {
+ accessor: 'database',
+ hidden: true,
+ disableSortBy: true,
+ },
+ {
+ accessor: 'schema',
+ Header: t('Schema'),
+ },
+ {
+ Cell: ({
+ row: {
+ original: { sql_tables: tables },
+ },
+ }: any) => {
+ const names = tables.map((table: any) => table.table);
+ const main = names.shift();
+
+ if (names.length) {
+ return (
+ <StyledTableLabel>
+ <span>{main}</span>
+ <Popover
+ placement="right"
+ title={t('TABLES')}
+ trigger="click"
+ content={
+ <>
+ {names.map((name: string) => (
+ <StyledPopoverItem>{name}</StyledPopoverItem>
+ ))}
+ </>
+ }
+ >
+ <span className="count">(+{names.length})</span>
+ </Popover>
+ </StyledTableLabel>
+ );
+ }
+
+ return main;
+ },
+ accessor: 'sql_tables',
+ Header: t('Tables'),
+ disableSortBy: true,
+ },
+ {
+ Cell: ({
+ row: {
+ original: { created_on: createdOn },
+ },
+ }: any) => createdOn,
+ Header: t('Created On'),
+ accessor: 'created_on',
+ },
+ {
+ Cell: ({
+ row: {
+ original: { changed_on_delta_humanized: changedOn },
+ },
+ }: any) => changedOn,
+ Header: t('Modified'),
+ accessor: 'changed_on_delta_humanized',
+ },
+ {
+ Cell: ({ row: { original } }: any) => {
+ const handlePreview = () => {}; // openQueryPreviewModal(original); // TODO: open preview modal
+ const handleEdit = () => {}; // handleQueryEdit(original); // TODO: navigate to sql editor with selected query open
+ const handleCopy = () => {}; // TODO: copy link to clipboard
+ const handleDelete = () => {}; // openQueryDeleteModal(original);
+
+ return (
+ <span className="actions">
+ <TooltipWrapper
+ label="preview-action"
+ tooltip={t('Query preview')}
+ placement="bottom"
+ >
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ onClick={handlePreview}
+ >
+ <Icon name="binoculars" />
+ </span>
+ </TooltipWrapper>
+ {canEdit && (
+ <TooltipWrapper
+ label="edit-action"
+ tooltip={t('Edit query')}
+ placement="bottom"
+ >
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ onClick={handleEdit}
+ >
+ <Icon name="pencil" />
+ </span>
+ </TooltipWrapper>
+ )}
+ <TooltipWrapper
+ label="copy-action"
+ tooltip={t('Copy query URL')}
+ placement="bottom"
+ >
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ onClick={handleCopy}
+ >
+ <Icon name="clipboard" />
+ </span>
+ </TooltipWrapper>
+ {canDelete && (
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ data-test="database-delete"
+ onClick={handleDelete}
+ >
+ <TooltipWrapper
+ label="delete-action"
+ tooltip={t('Delete query')}
+ placement="bottom"
+ >
+ <Icon name="trash" />
+ </TooltipWrapper>
+ </span>
+ )}
+ </span>
+ );
+ },
+ Header: t('Actions'),
+ id: 'actions',
+ disableSortBy: true,
+ },
+ ],
+ [canDelete, canCreate],
+ );
+
+ const filters: Filters = useMemo(
+ () => [
+ {
+ Header: t('Database'),
+ id: 'database',
+ input: 'select',
+ operator: 'rel_o_m',
+ unfilteredLabel: 'All',
+ fetchSelects: createFetchRelated(
+ 'saved_query',
+ 'database',
+ createErrorHandler(errMsg =>
+ t(
+ 'An error occurred while fetching dataset datasource values: %s',
+ errMsg,
+ ),
+ ),
+ ),
+ paginate: true,
+ },
+ {
+ Header: t('Schema'),
+ id: 'schema',
+ input: 'select',
+ operator: 'eq',
+ unfilteredLabel: 'All',
+ fetchSelects: createFetchDistinct(
+ 'saved_query',
+ 'schema',
+ createErrorHandler(errMsg =>
+ t('An error occurred while fetching schema values: %s', errMsg),
+ ),
+ ),
+ paginate: true,
+ },
+ {
+ Header: t('Search'),
+ id: 'label',
+ input: 'search',
+ operator: 'ct',
Review comment:
since https://github.com/apache/incubator-superset/pull/11031 just merged, can you rebase and switch this to `all_text` ?
##########
File path: superset-frontend/src/components/Icon/index.tsx
##########
@@ -17,6 +17,7 @@
* under the License.
*/
import React, { SVGProps } from 'react';
+import { ReactComponent as BinocularsIcon } from 'images/icons/binoculars.svg';
Review comment:
These icon additions may conflict with https://github.com/apache/incubator-superset/pull/11033 so we should probably coordinte with @rusackas
##########
File path: superset-frontend/src/components/Icon/index.tsx
##########
@@ -17,6 +17,7 @@
* under the License.
*/
import React, { SVGProps } from 'react';
+import { ReactComponent as BinocularsIcon } from 'images/icons/binoculars.svg';
Review comment:
These icon additions may conflict with https://github.com/apache/incubator-superset/pull/11033 so we should probably coordinte with @rusackas in this area
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] riahk closed pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
riahk closed pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3a08fd04f3f9ebaaa48fa554028c26062de42f02?el=desc) will **increase** coverage by `3.98%`.
> The diff coverage is `85.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
+ Coverage 61.70% 65.68% +3.98%
==========================================
Files 816 816
Lines 38586 38634 +48
Branches 3650 3655 +5
==========================================
+ Hits 23808 25377 +1569
+ Misses 14598 13154 -1444
+ Partials 180 103 -77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.51% <7.89%> (?)` | |
| #javascript | `62.25% <85.10%> (+0.06%)` | :arrow_up: |
| #python | `60.96% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `87.03% <85.10%> (-12.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.29% <0.00%> (-0.67%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.67% <0.00%> (-0.59%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [3a08fd0...80e36ac](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `84.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 61.57% 61.13% -0.45%
==========================================
Files 815 816 +1
Lines 38337 38446 +109
Branches 3599 3612 +13
==========================================
- Hits 23606 23503 -103
- Misses 14545 14757 +212
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.79% <84.44%> (+0.02%)` | :arrow_up: |
| #python | `60.74% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (+0.07%)` | :arrow_up: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `86.00% <83.72%> (-14.00%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `79.16% <0.00%> (-13.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.53% <0.00%> (-11.76%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `76.00% <0.00%> (-9.00%)` | :arrow_down: |
| [superset/queries/saved\_queries/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2ZpbHRlcnMucHk=) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `54.92% <0.00%> (-4.17%)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [e4e78b6...fed8e1c](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.47%`.
> The diff coverage is `84.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 61.57% 61.09% -0.48%
==========================================
Files 815 816 +1
Lines 38337 38446 +109
Branches 3599 3612 +13
==========================================
- Hits 23606 23490 -116
- Misses 14545 14770 +225
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.79% <84.44%> (+0.02%)` | :arrow_up: |
| #python | `60.68% <ø> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (+0.07%)` | :arrow_up: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `86.00% <83.72%> (-14.00%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `79.16% <0.00%> (-13.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.53% <0.00%> (-11.76%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `76.00% <0.00%> (-9.00%)` | :arrow_down: |
| [superset/queries/saved\_queries/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2ZpbHRlcnMucHk=) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [e4e78b6...fed8e1c](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#discussion_r495261085
##########
File path: superset-frontend/src/components/Icon/index.tsx
##########
@@ -17,6 +17,7 @@
* under the License.
*/
import React, { SVGProps } from 'react';
+import { ReactComponent as BinocularsIcon } from 'images/icons/binoculars.svg';
Review comment:
Merged that PR! Please feel free to rebase and use the new binoculars icon (_and many more_) from master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3a08fd04f3f9ebaaa48fa554028c26062de42f02?el=desc) will **decrease** coverage by `0.47%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 61.70% 61.22% -0.48%
==========================================
Files 816 383 -433
Lines 38586 24188 -14398
Branches 3650 0 -3650
==========================================
- Hits 23808 14809 -8999
+ Misses 14598 9379 -5219
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.22% <ø> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.27% <0.00%> (-8.69%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [superset-frontend/src/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvdXRpbHMuanM=) | | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | | |
| ... and [428 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [3a08fd0...80e36ac](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.44%`.
> The diff coverage is `84.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 61.57% 61.13% -0.45%
==========================================
Files 815 816 +1
Lines 38337 38446 +109
Branches 3599 3612 +13
==========================================
- Hits 23606 23503 -103
- Misses 14545 14757 +212
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.79% <84.44%> (+0.02%)` | :arrow_up: |
| #python | `60.74% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (+0.07%)` | :arrow_up: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `86.00% <83.72%> (-14.00%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `79.16% <0.00%> (-13.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.53% <0.00%> (-11.76%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `76.00% <0.00%> (-9.00%)` | :arrow_down: |
| [superset/queries/saved\_queries/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2ZpbHRlcnMucHk=) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `54.92% <0.00%> (-4.17%)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [e4e78b6...fed8e1c](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.47%`.
> The diff coverage is `84.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 61.57% 61.09% -0.48%
==========================================
Files 815 816 +1
Lines 38337 38446 +109
Branches 3599 3612 +13
==========================================
- Hits 23606 23490 -116
- Misses 14545 14770 +225
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.79% <84.44%> (+0.02%)` | :arrow_up: |
| #python | `60.68% <ø> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (+0.07%)` | :arrow_up: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `86.00% <83.72%> (-14.00%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `79.16% <0.00%> (-13.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.53% <0.00%> (-11.76%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `76.00% <0.00%> (-9.00%)` | :arrow_down: |
| [superset/queries/saved\_queries/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2ZpbHRlcnMucHk=) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [e4e78b6...fed8e1c](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1) Report
> Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3a08fd04f3f9ebaaa48fa554028c26062de42f02?el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
- Coverage 61.70% 61.41% -0.30%
==========================================
Files 816 383 -433
Lines 38586 24188 -14398
Branches 3650 0 -3650
==========================================
- Hits 23808 14854 -8954
+ Misses 14598 9334 -5264
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.22% <ø> (ø)` | |
| [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | | |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
| [superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9jb21tb24udHM=) | | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | | |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | | |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | | |
| [...rset-frontend/src/components/URLShortLinkModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rTW9kYWwuanN4) | | |
| ... and [423 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer). Last update [3a08fd0...80e36ac](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#discussion_r496239571
##########
File path: superset-frontend/images/icons/clipboard.svg
##########
@@ -0,0 +1,21 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<svg width="18" height="21" viewBox="0 0 18 21" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M18 7.44C17.9896 7.34813 17.9695 7.25763 17.94 7.17V7.08C17.8919 6.97718 17.8278 6.88267 17.75 6.8L11.75 0.8C11.6673 0.722216 11.5728 0.658081 11.47 0.61C11.4402 0.60576 11.4099 0.60576 11.38 0.61C11.2784 0.551741 11.1662 0.514344 11.05 0.5H7C5.34315 0.5 4 1.84315 4 3.5V4.5H3C1.34315 4.5 0 5.84315 0 7.5V17.5C0 19.1569 1.34315 20.5 3 20.5H11C12.6569 20.5 14 19.1569 14 17.5V16.5H15C16.6569 16.5 18 15.1569 18 13.5V7.5C18 7.5 18 7.5 18 7.44ZM12 3.91L14.59 6.5H13C12.4477 6.5 12 6.05228 12 5.5V3.91ZM12 17.5C12 18.0523 11.5523 18.5 11 18.5H3C2.44772 18.5 2 18.0523 2 17.5V7.5C2 6.94772 2.44772 6.5 3 6.5H4V13.5C4 15.1569 5.34315 16.5 7 16.5H12V17.5ZM16 13.5C16 14.0523 15.5523 14.5 15 14.5H7C6.44772 14.5 6 14.0523 6 13.5V3.5C6 2.94772 6.44772 2.5 7 2.5H10V5.5C10 7.15685 11.3431 8.5 13 8.5H16V13.5Z" fill="currentColor"/>
+</svg>
Review comment:
Looks like this file needs to be deleted, as this icon is not called `copy`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#discussion_r494514454
##########
File path: superset-frontend/src/components/Icon/index.tsx
##########
@@ -17,6 +17,7 @@
* under the License.
*/
import React, { SVGProps } from 'react';
+import { ReactComponent as BinocularsIcon } from 'images/icons/binoculars.svg';
Review comment:
These icon additions may conflict with https://github.com/apache/incubator-superset/pull/11033 so we should probably coordinte with @rusackas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#discussion_r494513003
##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -17,28 +17,283 @@
* under the License.
*/
-import React from 'react';
+import { t, styled } from '@superset-ui/core';
+import React, { useMemo } from 'react';
+import {
+ createFetchRelated,
+ createFetchDistinct,
+ createErrorHandler,
+} from 'src/views/CRUD/utils';
+import { Popover } from 'src/common/components';
import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { useListViewResource } from 'src/views/CRUD/hooks';
import SubMenu, { SubMenuProps } from 'src/components/Menu/SubMenu';
+import ListView, { Filters } from 'src/components/ListView';
+import TooltipWrapper from 'src/components/TooltipWrapper';
+import Icon from 'src/components/Icon';
import { commonMenuData } from 'src/views/CRUD/data/common';
+const PAGE_SIZE = 25;
+
interface SavedQueryListProps {
addDangerToast: (msg: string) => void;
addSuccessToast: (msg: string) => void;
}
+type SavedQueryObject = {};
+
+const StyledTableLabel = styled.div`
+ .count {
+ margin-left: 5px;
+ color: ${({ theme }) => theme.colors.primary.base};
+ text-decoration: underline;
+ cursor: pointer;
+ }
+`;
+
+const StyledPopoverItem = styled.div`
+ color: ${({ theme }) => theme.colors.grayscale.dark2};
+`;
+
function SavedQueryList({
addDangerToast,
addSuccessToast,
}: SavedQueryListProps) {
+ const {
+ state: { loading, resourceCount: queryCount, resourceCollection: queries },
+ hasPerm,
+ fetchData,
+ // refreshData, //TODO: add back later when editing?
+ } = useListViewResource<SavedQueryObject>(
+ 'saved_query',
+ t('saved_queries'),
+ addDangerToast,
+ );
+
+ const canCreate = hasPerm('can_add');
+ const canEdit = hasPerm('can_edit');
+ const canDelete = hasPerm('can_delete');
+
const menuData: SubMenuProps = {
activeChild: 'Saved Queries',
...commonMenuData,
};
+ const initialSort = [{ id: 'label', desc: true }];
+ const columns = useMemo(
+ () => [
+ {
+ accessor: 'label',
+ Header: t('Name'),
+ },
+ {
+ accessor: 'database.database_name',
+ Header: t('Database'),
+ },
+ {
+ accessor: 'database',
+ hidden: true,
+ disableSortBy: true,
+ },
+ {
+ accessor: 'schema',
+ Header: t('Schema'),
+ },
+ {
+ Cell: ({
+ row: {
+ original: { sql_tables: tables },
+ },
+ }: any) => {
+ const names = tables.map((table: any) => table.table);
+ const main = names.shift();
+
+ if (names.length) {
+ return (
+ <StyledTableLabel>
+ <span>{main}</span>
+ <Popover
+ placement="right"
+ title={t('TABLES')}
+ trigger="click"
+ content={
+ <>
+ {names.map((name: string) => (
+ <StyledPopoverItem>{name}</StyledPopoverItem>
+ ))}
+ </>
+ }
+ >
+ <span className="count">(+{names.length})</span>
+ </Popover>
+ </StyledTableLabel>
+ );
+ }
+
+ return main;
+ },
+ accessor: 'sql_tables',
+ Header: t('Tables'),
+ disableSortBy: true,
+ },
+ {
+ Cell: ({
+ row: {
+ original: { created_on: createdOn },
+ },
+ }: any) => createdOn,
+ Header: t('Created On'),
+ accessor: 'created_on',
+ },
+ {
+ Cell: ({
+ row: {
+ original: { changed_on_delta_humanized: changedOn },
+ },
+ }: any) => changedOn,
+ Header: t('Modified'),
+ accessor: 'changed_on_delta_humanized',
+ },
+ {
+ Cell: ({ row: { original } }: any) => {
+ const handlePreview = () => {}; // openQueryPreviewModal(original); // TODO: open preview modal
+ const handleEdit = () => {}; // handleQueryEdit(original); // TODO: navigate to sql editor with selected query open
+ const handleCopy = () => {}; // TODO: copy link to clipboard
+ const handleDelete = () => {}; // openQueryDeleteModal(original);
+
+ return (
+ <span className="actions">
+ <TooltipWrapper
+ label="preview-action"
+ tooltip={t('Query preview')}
+ placement="bottom"
+ >
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ onClick={handlePreview}
+ >
+ <Icon name="binoculars" />
+ </span>
+ </TooltipWrapper>
+ {canEdit && (
+ <TooltipWrapper
+ label="edit-action"
+ tooltip={t('Edit query')}
+ placement="bottom"
+ >
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ onClick={handleEdit}
+ >
+ <Icon name="pencil" />
+ </span>
+ </TooltipWrapper>
+ )}
+ <TooltipWrapper
+ label="copy-action"
+ tooltip={t('Copy query URL')}
+ placement="bottom"
+ >
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ onClick={handleCopy}
+ >
+ <Icon name="clipboard" />
+ </span>
+ </TooltipWrapper>
+ {canDelete && (
+ <span
+ role="button"
+ tabIndex={0}
+ className="action-button"
+ data-test="database-delete"
+ onClick={handleDelete}
+ >
+ <TooltipWrapper
+ label="delete-action"
+ tooltip={t('Delete query')}
+ placement="bottom"
+ >
+ <Icon name="trash" />
+ </TooltipWrapper>
+ </span>
+ )}
+ </span>
+ );
+ },
+ Header: t('Actions'),
+ id: 'actions',
+ disableSortBy: true,
+ },
+ ],
+ [canDelete, canCreate],
+ );
+
+ const filters: Filters = useMemo(
+ () => [
+ {
+ Header: t('Database'),
+ id: 'database',
+ input: 'select',
+ operator: 'rel_o_m',
+ unfilteredLabel: 'All',
+ fetchSelects: createFetchRelated(
+ 'saved_query',
+ 'database',
+ createErrorHandler(errMsg =>
+ t(
+ 'An error occurred while fetching dataset datasource values: %s',
+ errMsg,
+ ),
+ ),
+ ),
+ paginate: true,
+ },
+ {
+ Header: t('Schema'),
+ id: 'schema',
+ input: 'select',
+ operator: 'eq',
+ unfilteredLabel: 'All',
+ fetchSelects: createFetchDistinct(
+ 'saved_query',
+ 'schema',
+ createErrorHandler(errMsg =>
+ t('An error occurred while fetching schema values: %s', errMsg),
+ ),
+ ),
+ paginate: true,
+ },
+ {
+ Header: t('Search'),
+ id: 'label',
+ input: 'search',
+ operator: 'ct',
Review comment:
since https://github.com/apache/incubator-superset/pull/11031 just merged, can you rebase and switch this to `all_text` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #11005: feat: saved query list view + sort/filters
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#discussion_r494514454
##########
File path: superset-frontend/src/components/Icon/index.tsx
##########
@@ -17,6 +17,7 @@
* under the License.
*/
import React, { SVGProps } from 'react';
+import { ReactComponent as BinocularsIcon } from 'images/icons/binoculars.svg';
Review comment:
These icon additions may conflict with https://github.com/apache/incubator-superset/pull/11033 so we should probably coordinte with @rusackas in this area
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org