You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by lewismc <gi...@git.apache.org> on 2016/02/27 02:47:40 UTC
[GitHub] gora pull request: GORA-362 Refactor gora-dynamodb to support avro...
GitHub user lewismc opened a pull request:
https://github.com/apache/gora/pull/56
GORA-362 Refactor gora-dynamodb to support avro serialization
Hi @renato2099 OK here it is in all of it's glory... and what a patch it is!
This is a beast!
I've tested it locally and all working well. I updated a number of areas, fixed a few bugs and also made the patch compliant with the forbidden api's checks.
This issue relates to https://issues.apache.org/jira/browse/GORA-362
What an effort this was by you first time around... kudos mate.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/gora GORA-362
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit 655cd3aa846751f4805ef5e84ecd9193fe2c7aa2
Author: Lewis John McGibbney <le...@jpl.nasa.gov>
Date: 2016-02-27T01:48:49Z
GORA-362 Refactor gora-dynamodb to support avro serialization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-362 Refactor gora-dynamodb to support avro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-362 Refactor gora-dynamodb to support avro...
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/56#issuecomment-197347604
yeah I think we can at least start moving that direction :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-362 Refactor gora-dynamodb to support avro...
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/56#issuecomment-197380002
there still some more work to get it done, but I think we are moving in the right direction with this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-362 Refactor gora-dynamodb to support avro...
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/56#issuecomment-193119652
This is awesome mate! I really thought I had lost this.
Maybe we can commit this as an initial patch and start working from there? wdyt @lewismc ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-362 Refactor gora-dynamodb to support avro...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/56#issuecomment-194310859
I am +1 for it. In it's current state e.g. master, gora-dynamodb is kinda broken, It is also severaly behind the aws java SDK meaning that I am not even sure we can persist data into dynamodb anymore.
I would be +1 for committing this patch, it tests, it builds ,etc.
Anyone else have comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---