[GitHub] [incubator-superset] khtruong opened a new pull request #7625: View Presto row and array objects clearly in the data grid

[GitBox <gi...@apache.org>]

khtruong opened a new pull request #7625: View Presto row and array objects clearly in the data grid
URL: https://github.com/apache/incubator-superset/pull/7625
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   We do not immediately display Presto rows and arrays clearly in the data grid. This feature separates out nested fields and data values to help clearly display structural columns. Hopefully in the future, we can apply similar enhancements for other data sources.
   
   ### BEFORE SCREENSHOTS
   Here ColumnA is a row column that contains two nested fields 1) an integer field and 2) a string field. We cannot immediately tell what are the nested fields' names. If this was a more complicated column (i.e. The data type is row(nested_array1 array(row nested_field int, nested_array2 ...)))), then you can imagine how difficult it would be to read the data values.
   
   <img width="88" alt="Screen Shot 2019-05-16 at 11 50 16 AM" src="https://user-images.githubusercontent.com/47833996/58666517-6466e800-82e8-11e9-9ef1-bfbb1274004c.png">
   
   ### AFTER SCREENSHOTS
   Here we have pulled out the nested fields into its own columns. This is much more readable.
   
   <img width="510" alt="Screen Shot 2019-05-16 at 1 34 36 PM" src="https://user-images.githubusercontent.com/47833996/58666674-db03e580-82e8-11e9-8742-45b7eb863eef.png">
   Here ColumnB is an array where data values are pulled out into subsequent rows.
   
   <img width="418" alt="Screen Shot 2019-05-16 at 4 04 23 PM" src="https://user-images.githubusercontent.com/47833996/58666707-f111a600-82e8-11e9-99ff-d1e0f695e43e.png">
   
   (Note: Ignore the visual enhancements - grayed out columns and data values. We will be adding visual enhancements in a separate PR)
   
   
   ### TEST PLAN
   Tested manually and added unit tests
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @betodealmeida @DiggidyDave @xtinec @john-bodley @michellethomas @graceguo-supercat @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org