[jira] [Commented] (PDFBOX-2490) Return value of COSDocument#isEncrypted is unclear

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203430#comment-14203430 ] 

ASF subversion and git services commented on PDFBOX-2490:
---------------------------------------------------------

Commit 1637565 from [~lehmi] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1637565 ]

PDFBOX-2490: clarify the meaning of the return value of isEncrypted, added isDecrypted

> Return value of COSDocument#isEncrypted is unclear
> --------------------------------------------------
>
>                 Key: PDFBOX-2490
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2490
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing, PDModel
>    Affects Versions: 1.8.7, 2.0.0
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>              Labels: Encryption
>             Fix For: 1.8.8, 2.0.0
>
>
> According to the java doc COSDocument#isEncrypted provides if a pdf is encrypted or not. But it's not clear what it really means:
> - is the pdf somehow encrypted
> - is an encrypted pdf already decrypted after parsing
> I guess the first case was the origin intention of this method. Although a comment in the code indicates that the information is needed within the non-sequential parser I can't find any call of  COSDocument#isEncrypted anywhere in the non-sequential parser.
> I'm going to change the behaviour of isEncrypted so that it follows the origin intention and I'll add a new method isDecrypted as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)