You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/01 04:43:45 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #5395: ui: Allow searching in dropdowns
davidjumani opened a new pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395
### Description
Allows searching in dropdowns
Part of #3121 separated for simplicity
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-913972403
@davidjumani can you please resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-911475376
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-917852978
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5395 (SL-JID-641)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914975610
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914890651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914890971
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5395 (SL-JID-614)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-911510063
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-917851615
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914912460
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-915741758
@nvazquez Don't think that might be possible as we use ant internal methods to filter the text cc @utchoang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-911518442
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5395 (SL-JID-595)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#discussion_r699842335
##########
File path: ui/src/components/header/SamlDomainSwitcher.vue
##########
@@ -22,6 +22,11 @@
:loading="loading"
:defaultValue="currentAccount"
:value="currentAccount"
+ showSearch
+ optionFilterProp="children"
+ :filterOption="(input, option) => {
+ return option.componentOptions.children[0].text.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }"
Review comment:
@davidjumani this code is common across all select items. Is it possible to extract this and have a custom select component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-909882076
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5395 (SL-JID-587)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-909879565
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-909963791
@davidjumani can you add a search in dropdown for the following sections?
`src\components\view\DedicateDomain.vue` line 41,
`src\components\view\Login.vue` line 40, 107
`src\views\dashboard\CapacityDashboard.vue` line 23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-909879565
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-917853210
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5395 (SL-JID-642)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-918272149
Agree with @shwstppr, merging based on manual tests performed by him and myself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-909963791
@davidjumani can you add a search in dropdown for the following sections?
`src\components\view\DedicateDomain.vue` line 41,
`src\components\view\Login.vue` line 40, 107
`src\views\dashboard\CapacityDashboard.vue` line 23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-917993622
@shwstppr are you lgtm to merge this, then changes are large - should they be manually tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-917993622
@shwstppr are you lgtm in merge this, then changes are large - should they be manually tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#discussion_r700928625
##########
File path: ui/src/components/header/SamlDomainSwitcher.vue
##########
@@ -22,6 +22,11 @@
:loading="loading"
:defaultValue="currentAccount"
:value="currentAccount"
+ showSearch
+ optionFilterProp="children"
+ :filterOption="(input, option) => {
+ return option.componentOptions.children[0].text.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }"
Review comment:
I think that might involve replicating every prop used which could potentially break things. @utchoang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#discussion_r699842335
##########
File path: ui/src/components/header/SamlDomainSwitcher.vue
##########
@@ -22,6 +22,11 @@
:loading="loading"
:defaultValue="currentAccount"
:value="currentAccount"
+ showSearch
+ optionFilterProp="children"
+ :filterOption="(input, option) => {
+ return option.componentOptions.children[0].text.toLowerCase().indexOf(input.toLowerCase()) >= 0
+ }"
Review comment:
@davidjumani this code is common across all select items. Is it possible to extract this and have a custom select component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914933174
UI build: :heavy_multiplication_x:
(SL-JID-615)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-917850664
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914974890
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-909880126
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914984640
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5395 (SL-JID-616)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914912160
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914888810
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-911509170
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-914889605
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5395: ui: Allow searching in dropdowns
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#issuecomment-909880126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org