You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by jo...@apache.org on 2011/04/01 15:42:21 UTC

svn commit: r1087706 - /qpid/trunk/qpid/tools/src/py/qpid-config

Author: jonathan
Date: Fri Apr  1 13:42:20 2011
New Revision: 1087706

URL: http://svn.apache.org/viewvc?rev=1087706&view=rev
Log:
Corrected help text for --max-queue-size, --max-queue-count


Modified:
    qpid/trunk/qpid/tools/src/py/qpid-config

Modified: qpid/trunk/qpid/tools/src/py/qpid-config
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/tools/src/py/qpid-config?rev=1087706&r1=1087705&r2=1087706&view=diff
==============================================================================
--- qpid/trunk/qpid/tools/src/py/qpid-config (original)
+++ qpid/trunk/qpid/tools/src/py/qpid-config Fri Apr  1 13:42:20 2011
@@ -173,8 +173,8 @@ def OptionsAndArguments(argv):
     group3.add_option("--cluster-durable", action="store_true", help="The new queue becomes durable if there is only one functioning cluster node")
     group3.add_option("--file-count", action="store", type="int", default=8, metavar="<n>", help="Number of files in queue's persistence journal")
     group3.add_option("--file-size", action="store", type="int", default=24, metavar="<n>", help="File size in pages (64Kib/page)")
-    group3.add_option("--max-queue-size", action="store", type="int", metavar="<n>", help="Number of files in queue's persistence journal")
-    group3.add_option("--max-queue-count", action="store", type="int", metavar="<n>", help="Number of files in queue's persistence journal")
+    group3.add_option("--max-queue-size", action="store", type="int", metavar="<n>", help="Maximum in-memory queue size as bytes")
+    group3.add_option("--max-queue-count", action="store", type="int", metavar="<n>", help="Maximum in-memory queue size as a number of messages")
     group3.add_option("--limit-policy", action="store", choices=["none", "reject", "flow-to-disk", "ring", "ring-strict"], metavar="<policy>", help="Action to take when queue limit is reached")
     group3.add_option("--order", action="store", choices=["fifo", "lvq", "lvq-no-browse"], metavar="<ordering>", help="Queue ordering policy")
     group3.add_option("--generate-queue-events", action="store", type="int", metavar="<n>", help="If set to 1, every enqueue will generate an event that can be processed by registered listeners (e.g. for replication). If set to 2, events will be generated for enqueues and dequeues.")



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org


qpid-config usage incorrect: merge to 0-10? (was Re: svn commit: r1087706 - /qpid/trunk/qpid/tools/src/py/qpid-config)

Posted by Gordon Sim <gs...@redhat.com>.
On 04/01/2011 02:42 PM, jonathan@apache.org wrote:
> Author: jonathan
> Date: Fri Apr  1 13:42:20 2011
> New Revision: 1087706
>
> URL: http://svn.apache.org/viewvc?rev=1087706&view=rev
> Log:
> Corrected help text for --max-queue-size, --max-queue-count

This should really have a JIRA associated with it. It's also a 
regression from 0.8 so we may want to consider merging to 0-10. It is by 
no means a critical issue, but it does leave rather a bad impression.

>
>
> Modified:
>      qpid/trunk/qpid/tools/src/py/qpid-config
>
> Modified: qpid/trunk/qpid/tools/src/py/qpid-config
> URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/tools/src/py/qpid-config?rev=1087706&r1=1087705&r2=1087706&view=diff
> ==============================================================================
> --- qpid/trunk/qpid/tools/src/py/qpid-config (original)
> +++ qpid/trunk/qpid/tools/src/py/qpid-config Fri Apr  1 13:42:20 2011
> @@ -173,8 +173,8 @@ def OptionsAndArguments(argv):
>       group3.add_option("--cluster-durable", action="store_true", help="The new queue becomes durable if there is only one functioning cluster node")
>       group3.add_option("--file-count", action="store", type="int", default=8, metavar="<n>", help="Number of files in queue's persistence journal")
>       group3.add_option("--file-size", action="store", type="int", default=24, metavar="<n>", help="File size in pages (64Kib/page)")
> -    group3.add_option("--max-queue-size", action="store", type="int", metavar="<n>", help="Number of files in queue's persistence journal")
> -    group3.add_option("--max-queue-count", action="store", type="int", metavar="<n>", help="Number of files in queue's persistence journal")
> +    group3.add_option("--max-queue-size", action="store", type="int", metavar="<n>", help="Maximum in-memory queue size as bytes")
> +    group3.add_option("--max-queue-count", action="store", type="int", metavar="<n>", help="Maximum in-memory queue size as a number of messages")
>       group3.add_option("--limit-policy", action="store", choices=["none", "reject", "flow-to-disk", "ring", "ring-strict"], metavar="<policy>", help="Action to take when queue limit is reached")
>       group3.add_option("--order", action="store", choices=["fifo", "lvq", "lvq-no-browse"], metavar="<ordering>", help="Queue ordering policy")
>       group3.add_option("--generate-queue-events", action="store", type="int", metavar="<n>", help="If set to 1, every enqueue will generate an event that can be processed by registered listeners (e.g. for replication). If set to 2, events will be generated for enqueues and dequeues.")
>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:commits-subscribe@qpid.apache.org
>
>


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org