You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/28 14:20:41 UTC

[GitHub] [beam] olehborysevych opened a new pull request, #23402: [Playground] [Task] Removed unused dependency from Playground docker files

olehborysevych opened a new pull request, #23402:
URL: https://github.com/apache/beam/pull/23402

   addresses #23339 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] vchunikhin commented on a diff in pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
vchunikhin commented on code in PR #23402:
URL: https://github.com/apache/beam/pull/23402#discussion_r983117613


##########
playground/frontend/playground_components/pubspec.lock:
##########
@@ -0,0 +1,873 @@
+# Generated by pub

Review Comment:
   What is this file? At least, this file doesn't have Apache License comment above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] alexeyinkin commented on a diff in pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
alexeyinkin commented on code in PR #23402:
URL: https://github.com/apache/beam/pull/23402#discussion_r1029625330


##########
build.gradle.kts:
##########
@@ -142,6 +142,10 @@ tasks.rat {
     // Sample text file for Java quickstart
     "sdks/java/maven-archetypes/examples/sample.txt",
 
+   // Ignore Playground proto/grpc proto/dart generated wrappers
+    "playground/backend/internal/api/v1/api_grpc.pb.go",
+    "playground/frontend/playground_components/lib/src/api/v1/*.dart",

Review Comment:
   No need for this because this merge is pending: https://github.com/apache/beam/pull/23378/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] olehborysevych commented on pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #23402:
URL: https://github.com/apache/beam/pull/23402#issuecomment-1260989625

   R: @vchunikhin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23402:
URL: https://github.com/apache/beam/pull/23402#issuecomment-1261012301

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] olehborysevych commented on pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #23402:
URL: https://github.com/apache/beam/pull/23402#issuecomment-1323846081

   R: @eantyshev, @alexeyinkin  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] eantyshev commented on a diff in pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
eantyshev commented on code in PR #23402:
URL: https://github.com/apache/beam/pull/23402#discussion_r1029551985


##########
build.gradle.kts:
##########
@@ -142,6 +142,10 @@ tasks.rat {
     // Sample text file for Java quickstart
     "sdks/java/maven-archetypes/examples/sample.txt",
 
+   // Ignore Playground proto/grpc proto/dart generated wrappers
+    "playground/backend/internal/api/v1/api_grpc.pb.go",

Review Comment:
   ```suggestion
       "playground/backend/internal/api/v1/api.pb.go",
       "playground/backend/internal/api/v1/api_grpc.pb.go",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] vchunikhin commented on pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
vchunikhin commented on PR #23402:
URL: https://github.com/apache/beam/pull/23402#issuecomment-1265671604

   lgfm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] alexeyinkin commented on a diff in pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
alexeyinkin commented on code in PR #23402:
URL: https://github.com/apache/beam/pull/23402#discussion_r1029625330


##########
build.gradle.kts:
##########
@@ -142,6 +142,10 @@ tasks.rat {
     // Sample text file for Java quickstart
     "sdks/java/maven-archetypes/examples/sample.txt",
 
+   // Ignore Playground proto/grpc proto/dart generated wrappers
+    "playground/backend/internal/api/v1/api_grpc.pb.go",
+    "playground/frontend/playground_components/lib/src/api/v1/*.dart",

Review Comment:
   No need for the Dart line here because this merge is pending: https://github.com/apache/beam/pull/23378/files#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] olehborysevych closed pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files

Posted by GitBox <gi...@apache.org>.
olehborysevych closed pull request #23402: [Playground] [Task] Removed unused dependency from Playground docker files
URL: https://github.com/apache/beam/pull/23402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org